Skip to content

Commit

Permalink
Merge branch 'master' into rule/add-RSPEC-S7132
Browse files Browse the repository at this point in the history
  • Loading branch information
tomasz-kaminski-sonarsource authored Nov 12, 2024
2 parents 44da97d + b2e18a8 commit 6da61f8
Show file tree
Hide file tree
Showing 432 changed files with 4,030 additions and 2,378 deletions.
29 changes: 29 additions & 0 deletions .github/workflows/PullRequestClosed.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Pull Request Closed

on:
pull_request:
types: [closed]

jobs:
PullRequestMerged_job:
name: Pull Request Merged
runs-on: ubuntu-latest
permissions:
id-token: write
pull-requests: read
# For external PR, ticket should be moved manually
if: |
github.event.pull_request.head.repo.full_name == github.repository
&& github.event.pull_request.merged
steps:
- id: secrets
uses: SonarSource/vault-action-wrapper@v3
with:
secrets: |
development/kv/data/jira user | JIRA_USER;
development/kv/data/jira token | JIRA_TOKEN;
- uses: sonarsource/gh-action-lt-backlog/PullRequestClosed@v2
with:
github-token: ${{secrets.GITHUB_TOKEN}}
jira-user: ${{ fromJSON(steps.secrets.outputs.vault).JIRA_USER }}
jira-token: ${{ fromJSON(steps.secrets.outputs.vault).JIRA_TOKEN }}
28 changes: 28 additions & 0 deletions .github/workflows/RequestReview.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Request review

on:
pull_request:
types: ["review_requested"]

jobs:
RequestReview_job:
name: Request review
runs-on: ubuntu-latest
permissions:
id-token: write
# For external PR, ticket should be moved manually
if: |
github.event.pull_request.head.repo.full_name == github.repository
steps:
- id: secrets
uses: SonarSource/vault-action-wrapper@v3
with:
secrets: |
development/github/token/{REPO_OWNER_NAME_DASH}-jira token | GITHUB_TOKEN;
development/kv/data/jira user | JIRA_USER;
development/kv/data/jira token | JIRA_TOKEN;
- uses: sonarsource/gh-action-lt-backlog/RequestReview@v2
with:
github-token: ${{ fromJSON(steps.secrets.outputs.vault).GITHUB_TOKEN }}
jira-user: ${{ fromJSON(steps.secrets.outputs.vault).JIRA_USER }}
jira-token: ${{ fromJSON(steps.secrets.outputs.vault).JIRA_TOKEN }}
30 changes: 30 additions & 0 deletions .github/workflows/SubmitReview.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: Submit Review

on:
pull_request_review:
types: [submitted]

jobs:
SubmitReview_job:
name: Submit Review
runs-on: ubuntu-latest
permissions:
id-token: write
pull-requests: read
# For external PR, ticket should be moved manually
if: |
github.event.pull_request.head.repo.full_name == github.repository
&& (github.event.review.state == 'changes_requested'
|| github.event.review.state == 'approved')
steps:
- id: secrets
uses: SonarSource/vault-action-wrapper@v3
with:
secrets: |
development/kv/data/jira user | JIRA_USER;
development/kv/data/jira token | JIRA_TOKEN;
- uses: sonarsource/gh-action-lt-backlog/SubmitReview@v2
with:
github-token: ${{secrets.GITHUB_TOKEN}}
jira-user: ${{ fromJSON(steps.secrets.outputs.vault).JIRA_USER }}
jira-token: ${{ fromJSON(steps.secrets.outputs.vault).JIRA_TOKEN }}
2 changes: 1 addition & 1 deletion docs/metadata.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ You can update the quickfix field using this GitHub Workflow: https://github.com

The code field is an object that contains information related to the clean code taxonomy. It is an object with two required properties:

* `impacts`: A nested object that is treated as a mapping from a software quality to a level (`"LOW"`, `"MEDIUM"` or `"HIGH"`). Note that at least one software quality has to be specified. The current list of allowed software qualities is `"MAINTAINABILITY"`, `"RELIABILITY"` and `"SECURITY"`.
* `impacts`: A nested object that is treated as a mapping from a software quality to a level (`"INFO"`, `"LOW"`, `"MEDIUM"`, `"HIGH"` or `"BLOCKER"`). Note that at least one software quality has to be specified. The current list of allowed software qualities is `"MAINTAINABILITY"`, `"RELIABILITY"` and `"SECURITY"`.

* `attribute`: A single clean code attribute that the rule aims to achieve. This has to be one of the following values: `"FORMATTED"`, `"CONVENTIONAL"`, `"IDENTIFIABLE"`, `"CLEAR"`, `"LOGICAL"`, `"COMPLETE"`, `"EFFICIENT"`, `"FOCUSED"`, `"DISTINCT"`, `"MODULAR"`, `"TESTED"`, `"LAWFUL"`, `"TRUSTWORTHY"`, `"RESPECTFUL"`.
232 changes: 154 additions & 78 deletions frontend/public/covered_rules.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,21 +102,21 @@
"ANSIBLE": {
"S1135": "sonar-iac-enterprise 1.37.0.12742",
"S2260": "sonar-iac-enterprise 1.37.0.12742",
"S2612": "sonar-iac-enterprise master",
"S4830": "sonar-iac-enterprise master",
"S5332": "sonar-iac-enterprise master",
"S5849": "sonar-iac-enterprise master",
"S6321": "sonar-iac-enterprise master",
"S6428": "sonar-iac-enterprise master",
"S6429": "sonar-iac-enterprise master",
"S6430": "sonar-iac-enterprise master",
"S6431": "sonar-iac-enterprise master",
"S6433": "sonar-iac-enterprise master",
"S6437": "sonar-iac-enterprise master",
"S6473": "sonar-iac-enterprise master",
"S6596": "sonar-iac-enterprise master",
"S6867": "sonar-iac-enterprise master",
"S6868": "sonar-iac-enterprise master"
"S2612": "sonar-iac-enterprise 1.38.0.13264",
"S4830": "sonar-iac-enterprise 1.38.0.13264",
"S5332": "sonar-iac-enterprise 1.38.0.13264",
"S5849": "sonar-iac-enterprise 1.38.0.13264",
"S6321": "sonar-iac-enterprise 1.38.0.13264",
"S6428": "sonar-iac-enterprise 1.38.0.13264",
"S6429": "sonar-iac-enterprise 1.38.0.13264",
"S6430": "sonar-iac-enterprise 1.38.0.13264",
"S6431": "sonar-iac-enterprise 1.38.0.13264",
"S6433": "sonar-iac-enterprise 1.38.0.13264",
"S6437": "sonar-iac-enterprise 1.38.0.13264",
"S6473": "sonar-iac-enterprise 1.38.0.13264",
"S6596": "sonar-iac-enterprise 1.38.0.13264",
"S6867": "sonar-iac-enterprise 1.38.0.13264",
"S6868": "sonar-iac-enterprise 1.38.0.13264"
},
"APEX": {
"S100": "sonar-apex 1.17.0.87",
Expand Down Expand Up @@ -2064,7 +2064,7 @@
"S1206": "sonar-dart 0.1.0.1359",
"S121": "sonar-dart 0.1.0.1359",
"S1481": "sonar-dart 0.1.0.1359",
"S1541": "sonar-dart master",
"S1541": "sonar-dart 0.4.0.1887",
"S1578": "sonar-dart 0.1.0.1359",
"S1679": "sonar-dart 0.1.0.1359",
"S1854": "sonar-dart 0.1.0.1359",
Expand Down Expand Up @@ -4755,6 +4755,7 @@
"S6395": "sonar-php 3.23.0.8726",
"S6396": "sonar-php 3.23.0.8726",
"S6397": "sonar-php 3.23.0.8726",
"S6418": "sonar-php master",
"S6437": "sonar-php 3.29.0.9684",
"S6600": "sonar-php 3.29.0.9684",
"S7044": "sonar-security 10.7.0.32997",
Expand Down Expand Up @@ -5478,96 +5479,171 @@
"S6292": "sonar-secrets 1.1.0.36766",
"S6334": "sonar-secrets 1.1.0.36766",
"S6335": "sonar-secrets 1.1.0.36766",
"S6336": "sonar-secrets 1.1.0.36766",
"S6337": "sonar-secrets 1.1.0.36766",
"S6336": {
"since": "sonar-secrets 1.1.0.36766",
"until": "sonar-text 2.5.0.2293"
},
"S6337": {
"since": "sonar-secrets 1.1.0.36766",
"until": "sonar-text 2.5.0.2293"
},
"S6338": "sonar-secrets 1.1.0.36766",
"S6652": {
"since": "sonar-text 2.2.0.1571",
"until": "sonar-text 2.2.0.1571"
},
"S6684": "sonar-text 2.3.0.1632",
"S6686": "sonar-text 2.3.0.1632",
"S6686": {
"since": "sonar-text 2.3.0.1632",
"until": "sonar-text 2.5.0.2293"
},
"S6687": "sonar-text 2.3.0.1632",
"S6688": "sonar-text 2.3.0.1632",
"S6688": {
"since": "sonar-text 2.3.0.1632",
"until": "sonar-text 2.5.0.2293"
},
"S6689": "sonar-text 2.3.0.1632",
"S6690": "sonar-text 2.3.0.1632",
"S6691": "sonar-text 2.3.0.1632",
"S6692": "sonar-text 2.3.0.1632",
"S6691": {
"since": "sonar-text 2.3.0.1632",
"until": "sonar-text 2.5.0.2293"
},
"S6692": {
"since": "sonar-text 2.3.0.1632",
"until": "sonar-text 2.5.0.2293"
},
"S6693": "sonar-text 2.3.0.1632",
"S6694": "sonar-text 2.3.0.1632",
"S6695": "sonar-text 2.3.0.1632",
"S6696": "sonar-text 2.3.0.1632",
"S6695": {
"since": "sonar-text 2.3.0.1632",
"until": "sonar-text 2.5.0.2293"
},
"S6696": {
"since": "sonar-text 2.3.0.1632",
"until": "sonar-text 2.5.0.2293"
},
"S6697": "sonar-text 2.3.0.1632",
"S6698": "sonar-text 2.3.0.1632",
"S6699": "sonar-text 2.3.0.1632",
"S6700": "sonar-text 2.3.0.1632",
"S6699": {
"since": "sonar-text 2.3.0.1632",
"until": "sonar-text 2.5.0.2293"
},
"S6700": {
"since": "sonar-text 2.3.0.1632",
"until": "sonar-text 2.5.0.2293"
},
"S6701": "sonar-text 2.3.0.1632",
"S6702": "sonar-text 2.3.0.1632",
"S6703": "sonar-text 2.3.0.1632",
"S6704": "sonar-text 2.3.0.1632",
"S6705": "sonar-text 2.3.0.1632",
"S6704": {
"since": "sonar-text 2.3.0.1632",
"until": "sonar-text 2.5.0.2293"
},
"S6705": {
"since": "sonar-text 2.3.0.1632",
"until": "sonar-text 2.5.0.2293"
},
"S6706": "sonar-text 2.3.0.1632",
"S6708": "sonar-text 2.4.0.2120",
"S6710": "sonar-text 2.4.0.2120",
"S6713": "sonar-text 2.4.0.2120",
"S6717": "sonar-text 2.4.0.2120",
"S6718": "sonar-text 2.4.0.2120",
"S6719": "sonar-text 2.4.0.2120",
"S6720": "sonar-text 2.4.0.2120",
"S6721": "sonar-text 2.4.0.2120",
"S6722": "sonar-text 2.4.0.2120",
"S6723": "sonar-text 2.4.0.2120",
"S6731": "sonar-text 2.4.0.2120",
"S6732": "sonar-text 2.4.0.2120",
"S6733": "sonar-text 2.4.0.2120",
"S6736": "sonar-text 2.4.0.2120",
"S6710": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6713": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6717": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6718": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6719": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6720": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6721": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6722": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6723": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6731": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6732": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6733": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6736": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6739": "sonar-text 2.4.0.2120",
"S6751": "sonar-text 2.4.0.2120",
"S6752": "sonar-text 2.4.0.2120",
"S6753": "sonar-text 2.4.0.2120",
"S6755": "sonar-text 2.4.0.2120",
"S6753": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6755": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6758": "sonar-text 2.4.0.2120",
"S6760": "sonar-text 2.4.0.2120",
"S6760": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6762": "sonar-text 2.4.0.2120",
"S6764": "sonar-text 2.4.0.2120",
"S6765": "sonar-text 2.4.0.2120",
"S6768": "sonar-text 2.4.0.2120",
"S6769": "sonar-text 2.4.0.2120",
"S6764": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6765": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6768": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6769": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6771": "sonar-text 2.4.0.2120",
"S6773": "sonar-text 2.4.0.2120",
"S6777": "sonar-text 2.4.0.2120",
"S6773": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6777": {
"since": "sonar-text 2.4.0.2120",
"until": "sonar-text 2.5.0.2293"
},
"S6782": "sonar-text 2.4.0.2120",
"S6783": "sonar-text 2.4.0.2120",
"S6910": "sonar-text master",
"S6987": "sonar-secrets 1.1.0.36766",
"S6988": "sonar-text master",
"S6989": "sonar-text master",
"S6990": "sonar-text master",
"S6992": "sonar-text master",
"S6993": "sonar-text master",
"S6995": "sonar-text master",
"S6997": "sonar-text master",
"S6998": "sonar-text master",
"S6999": "sonar-text master",
"S7000": "sonar-text master",
"S7001": "sonar-text master",
"S7002": "sonar-text master",
"S7003": "sonar-text master",
"S7004": "sonar-text master",
"S7006": "sonar-text master",
"S7007": "sonar-text master",
"S7008": "sonar-text master",
"S7009": "sonar-text master",
"S7010": "sonar-text master",
"S7011": "sonar-text master",
"S7013": "sonar-text master",
"S7014": "sonar-text master",
"S7015": "sonar-text master",
"S7016": "sonar-text master",
"S7017": "sonar-text master",
"S7022": "sonar-text master",
"S7024": "sonar-text master",
"S7025": "sonar-text master"
"S7013": "sonar-text master"
},
"SWIFT": {
"S100": "sonar-swift 3.1.0.2067",
Expand Down
Loading

0 comments on commit 6da61f8

Please sign in to comment.