Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARPY-2489 Create rule S7189 PySpark DataFrames used multiple times should be cached or persisted #4627

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@guillaume-dequenne guillaume-dequenne force-pushed the rule/add-RSPEC-S7189 branch 3 times, most recently from 1a4b36b to b50d55c Compare January 28, 2025 15:36
Copy link
Contributor

@thomas-serre-sonarsource thomas-serre-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I would just suggest to add tags in the metadata

Comment on lines 9 to 10
"tags": [
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding the pyspark and data-science tags? we did so in our PR with David.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I keep forgetting about these...

@guillaume-dequenne guillaume-dequenne changed the title Create rule S7189 SONARPY-2489 Create rule S7189 PySpark DataFrames used multiple times should be cached or persisted Jan 30, 2025
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@thomas-serre-sonarsource thomas-serre-sonarsource marked this pull request as ready for review January 30, 2025 13:15
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@guillaume-dequenne guillaume-dequenne merged commit 13111e2 into master Feb 18, 2025
9 of 10 checks passed
@guillaume-dequenne guillaume-dequenne deleted the rule/add-RSPEC-S7189 branch February 18, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants