Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S5527: Server hostnames should be verified during SSL/TLS connections for go #4656

Merged
merged 7 commits into from
Feb 12, 2025

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@github-actions github-actions bot added the go label Feb 10, 2025
@teemu-rytilahti-sonarsource teemu-rytilahti-sonarsource changed the title Create rule S5527 Create rule S5527: Server hostnames should be verified during SSL/TLS connections for go Feb 10, 2025
@teemu-rytilahti-sonarsource teemu-rytilahti-sonarsource marked this pull request as ready for review February 10, 2025 16:59
Copy link
Contributor

@daniel-teuchert-sonarsource daniel-teuchert-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me! ✅
I only have two minor suggestions.

rules/S5527/go/rule.adoc Outdated Show resolved Hide resolved
rules/S5527/go/how-to-fix-it/std.adoc Outdated Show resolved Hide resolved
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@teemu-rytilahti-sonarsource teemu-rytilahti-sonarsource merged commit 2619fbc into master Feb 12, 2025
9 of 10 checks passed
@teemu-rytilahti-sonarsource teemu-rytilahti-sonarsource deleted the rule/S5527-add-go branch February 12, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants