NO-JIRA: Updated doc for protoc command #2076
Conversation
|
| @@ -1,5 +1,6 @@ | |||
| To run: | |||
|
|
|||
| in `python-frontend/src/main/protobuf` directory, run: ```protoc -I=. --python_out=../../../typeshed_serializer/serializer/proto_out ./symbols.proto``` | |||
| in `python-frontend/src/main/protobuf` directory, run: | |||
There was a problem hiding this comment.
What does this do? Do we need it?
On my side I had some issues with Protobuf but eventually manage to sort them, and I didn't need to run a different command.
There was a problem hiding this comment.
I had an issue with the proto3_optional on my side, but it could be related to my version of the protobuf compiler. If you can generate the Python files without errors and without the flag then we should not bother changing the command.
There was a problem hiding this comment.
Yeah I had issues as well and after reinstalling it, it went fine. I suggest we close the PR if it's fine for you as well (unless the added command has intrinsic benefits you identified).
|
No description provided.