-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONARPY-2355 Update licenses to SSALv1 #2169
Conversation
e35273e
to
a38659a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the missing link to the license file, it looks good to me.
SQRP-80 mentions that projects that should remain under LGPL need to modify the pom.xml accordingly. But this doesn't apply to any of the projects in this repo, right?
README.md
Outdated
@@ -82,4 +82,6 @@ To fix that please execute: `mvn license:format`. | |||
|
|||
Copyright 2011-2024 SonarSource. | |||
|
|||
Licensed under the [GNU Lesser General Public License, Version 3.0](http://www.gnu.org/licenses/lgpl.txt) | |||
SonarQube analyzers released after November 29, 2024, including patch fixes for prior versions, are published under the Sonar Source-Available License Version 1 (SSALv1). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to SQRP-80, the readme should link to the LICENSE.txt file
a38659a
to
9051e21
Compare
It would apply to the That said, the serializer under this repo should also move to SSALv1, and I realize my initial changes didn't account for that. |
1db4bfe
to
a973336
Compare
157ae61
to
53e065d
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Context for the format update of
license-maven-plugin
: see this PR. Not respecting the new format prevented our custom configuration from being taken into account (Python files were neither checked nor updated).Currently, SSALv1 itself is flagged as a forbidden dependency for our internal checks. Because of this, they are overridden in our checks (see BUILD-7017).