SONARPY-2362 Document no issue on S6542 when inheriting from annotated class member #2174
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
guillaume-dequenne-sonarsource
force-pushed
the
document-S6542-behavior
branch
from
87ba87b
to
4fd7710
Compare
guillaume-dequenne-sonarsource
force-pushed
the
document-S6542-behavior
branch
from
4fd7710
to
478bd09
Compare
guillaume-dequenne-sonarsource
requested a review
from maksim-grebeniuk-sonarsource
| @@ -14,3 +14,7 @@ def imported_inherited_foo(self) -> Any: # Noncompliant | |||
| class ImportedWithMetaClassInherited(ImportedParentWithMetaClass): | |||
| def imported_inherited_foo(self) -> Any: # Noncompliant | |||
| ... | |||
|
|
|||
| class MyChild(MyClassWithAnnotatedMember): | |||
There was a problem hiding this comment.
Since now we have the more significant difference between locally defined and imported types for v1 type inference, it would be nice to show it in tests as well:
from typing import Callable
class LocalClassWithAnnotatedMember:
my_member: Callable[[Any],Any] # No issue on nested values of "Callable"
class LocalClassChild(LocalClassWithAnnotatedMember):
def my_member(self, param: Any) -> Any: # OK, defined in parent
...
maksim-grebeniuk-sonarsource
requested changes
Nov 25, 2024
|
maksim-grebeniuk-sonarsource
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARPY-2362