Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPY-2363 Document no issue on S1172 when inheriting from annotated class member #2175

Merged
merged 2 commits into from
Nov 26, 2024
Merged

SONARPY-2363 Document no issue on S1172 when inheriting from annotated class member #2175

merged 2 commits into from
Nov 26, 2024
+17 −1

Conversation

guillaume-dequenne-sonarsource
Copy link
Contributor

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource commented Nov 22, 2024 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Document no issue on S1172 when inheriting from annotated class member SONARPY-2363 Document no issue on S1172 when inheriting from annotated class member Nov 22, 2024
@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource marked this pull request as ready for review November 22, 2024 10:34
maksim-grebeniuk-sonarsource
maksim-grebeniuk-sonarsource requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one test case I think we need to add:
Since for now we have more significant difference between imported and locally defined type information processing it would be nice to have the same example but with locally defined parent

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

maksim-grebeniuk-sonarsource
maksim-grebeniuk-sonarsource approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maksim-grebeniuk-sonarsource maksim-grebeniuk-sonarsource merged commit a7ce426 into master Nov 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksim-grebeniuk-sonarsource maksim-grebeniuk-sonarsource maksim-grebeniuk-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillaume-dequenne-sonarsource @maksim-grebeniuk-sonarsource