Skip to content

Commit

Permalink
SQRP-123 Update logos
Browse files Browse the repository at this point in the history
  • Loading branch information
anita-stanisz-sonarsource authored and zipengwu committed Jan 20, 2025
1 parent 0026efd commit a0f2a1f
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public String getIcon() {
return "";
}

return "/plugin/" + wrapper.getShortName() + "/images/waves_16x16.png";
return "/plugin/" + wrapper.getShortName() + "/images/SonarQube_Mark.png";

This comment has been minimized.

Copy link
@jonesbusy

jonesbusy Jan 21, 2025

png are deprecated in favor of svg symbols : https://weekly.ci.jenkins.io/design-library/symbols/

I would suggest to drop your svg under src/main/resources/images/symbols

and reference it on the getIconFileName

return "symbol-sonarqube-mark plugin-sonar';

This comment has been minimized.

Copy link
@zipengwu

zipengwu Jan 23, 2025

Contributor

Hi @jonesbusy, thanks a lot for pointing this out. I will add a ticket in our backlog and we will try to tackle it in our next sprint.

In the meanwhile, will it be ok to allow us to release without your suggested change ? (Sonar is going through a rebranding effort which would like sync the logo across products as soon as possible)

}

// non use interface methods
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public SonarProjectIconAction(SonarAnalysisAction buildInfo) {
public String getIconFileName() {
PluginWrapper wrapper = Jenkins.getInstanceOrNull().getPluginManager()
.getPlugin(SonarPlugin.class);
return "/plugin/" + wrapper.getShortName() + "/images/waves_48x48.png";
return "/plugin/" + wrapper.getShortName() + "/images/SonarQube_Mark.png";
}

@Override
Expand Down
Binary file added src/main/webapp/images/SonarQube_Mark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed src/main/webapp/images/waves_16x16.png
Binary file not shown.
Binary file removed src/main/webapp/images/waves_48x48.png
Binary file not shown.

0 comments on commit a0f2a1f

Please sign in to comment.