Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows bat execution #1692

Closed
wants to merge 7 commits into from
Closed

fix windows bat execution #1692

wants to merge 7 commits into from

Conversation

faulycoelho
Copy link

@faulycoelho faulycoelho commented Sep 17, 2023

Fixes #1706
In the workflow for windows environment exist a process to append '^' three times before every single char, this is preventing correct execution.
After the correction, the dotnet sonarscanner end works well.

@pavel-mikula-sonarsource
Copy link
Contributor

Hi @faulycoelho,

Can you please create a new issue first, with full description, and with the mention of the old one? The old issue is closed.

Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests required.

@faulycoelho
Copy link
Author

Hi @faulycoelho,

Can you please create a new issue first, with full description, and with the mention of the old one? The old issue is closed.

Done: #1706

@faulycoelho
Copy link
Author

Tests required.

Tests created, committed.

@costin-zaharia-sonarsource
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).

@martin-strecker-sonarsource
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).

@faulycoelho
Copy link
Author

Fixed testing and escaping to use '^^^' like the previous version, but only with special characters.

@martin-strecker-sonarsource
Copy link
Contributor

martin-strecker-sonarsource commented Nov 20, 2023

Hello @faulycoelho
I took a look into this strange behavior and tried to reproduce the exact problem here #1751, here #1752, and here #1765. We still do not fully understand what is causing the problem on your side. As far as I can tell, it is related to a different behavior between Java 17 and Java 11 with respect to argument handling.
We need to add proper tests like in #1765 in place first before we can fix the issue like in #1751. Thank you for pointing us in the right direction, but as long as we do not know what exact string pattern is causing the problem and how we deal with it, we will need to stick to the current escaping mechanism for the moment. See also my comment here regarding the possible root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SonarScanner for .net doesn't sending result to server.
5 participants