Run on our infrastructure #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastien-marichal
changed the title
sebastien-marichal
force-pushed
the
sma/scan4net-7
branch
from
72e50ae
to
7b666ac
Compare
sebastien-marichal
force-pushed
the
sma/scan4net-7
branch
from
7b666ac
to
850be32
Compare
sebastien-marichal
force-pushed
the
sma/scan4net-7
branch
3 times, most recently
from
c64f4c9
to
845aae5
Compare
azure-pipelines.yml
Outdated
Comment on lines
202
to
190
| - powershell: | | ||
| nuget help | Select-String "NuGet Version" | ||
| nuget pack 'nuspec\netcoreglobaltool\dotnet-sonarscanner.nuspec' -NonInteractive -OutputDirectory build -Verbosity Detailed |
There was a problem hiding this comment.
NuGetCommand@2 uses an older version of nuget.exe
costin-zaharia-sonarsource
force-pushed
the
sma/scan4net-7
branch
from
845aae5
to
71fb1b3
Compare
zsolt-kolbay-sonarsource
force-pushed
the
sma/scan4net-7
branch
2 times, most recently
from
f86d098
to
004e31f
Compare
zsolt-kolbay-sonarsource
force-pushed
the
sma/scan4net-7
branch
from
004e31f
to
f280c0f
Compare
Tim-Pohlmann
requested changes
Jun 20, 2024
zsolt-kolbay-sonarsource
force-pushed
the
sma/scan4net-7
branch
from
1146afa
to
a78561c
Compare
|
Comment on lines
72
to
+75
| - task: NuGetToolInstaller@1 | ||
| displayName: "Install NuGet" | ||
| inputs: | ||
| versionSpec: $(NUGET_VERSION) |
There was a problem hiding this comment.
If it runs on our infrastructure, we don't need to install NuGet.
Why is this needed?
I remembered, I removed it.
There was a problem hiding this comment.
It seems the Nuget installed on the CI image doesn't work, the Package dotnet global tool task fails:
NuGet Version: 4.9.6.8
Attempting to build package from 'dotnet-sonarscanner.nuspec'.
System.InvalidOperationException: The element 'metadata' in namespace 'http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd' has invalid child element 'readme' in namespace 'http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd'. List of possible elements expected: 'serviceable, dependencies, repository, licenseUrl, copyright, references, packageTypes, contentFiles, releaseNotes, tags, language, developmentDependency, frameworkAssemblies, owners' in namespace 'http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd'. This validation error occurred in a 'readme' element.
at NuGet.Packaging.Manifest.<>c.<ValidateManifestSchema>b__20_0(Object sender, ValidationEventArgs e)
at System.Xml.Schema.XmlSchemaValidator.ValidateElementContext(XmlQualifiedName elementName, Boolean& invalidElementInContext)
at System.Xml.Schema.XmlSchemaValidator.ValidateElement(String localName, String namespaceUri, XmlSchemaInfo schemaInfo, String xsiType, String xsiNil, String xsiSchemaLocation, String xsiNoNamespaceSchemaLocation)
at System.Xml.Schema.XNodeValidator.ValidateElement(XElement e)
at System.Xml.Schema.XNodeValidator.ValidateNodes(XElement e)
at System.Xml.Schema.XNodeValidator.ValidateElement(XElement e)
at System.Xml.Schema.XNodeValidator.ValidateNodes(XElement e)
at System.Xml.Schema.XNodeValidator.ValidateElement(XElement e)
at System.Xml.Schema.XNodeValidator.Validate(XObject source, XmlSchemaObject partialValidationType, Boolean addSchemaInfo)
at NuGet.Packaging.Manifest.ValidateManifestSchema(XDocument document, String schemaNamespace)
at NuGet.Packaging.Manifest.ReadFrom(Stream stream, Func`2 propertyProvider, Boolean validateSchema)
at NuGet.Packaging.PackageBuilder.ReadManifest(Stream stream, String basePath, Func`2 propertyProvider)
at NuGet.Packaging.PackageBuilder..ctor(String path, String basePath, Func`2 propertyProvider, Boolean includeEmptyDirectories)
at NuGet.Commands.PackCommandRunner.CreatePackageBuilderFromNuspec(String path)
at NuGet.Commands.PackCommandRunner.BuildFromNuspec(String path)
at NuGet.Commands.PackCommandRunner.BuildPackage()
at NuGet.CommandLine.PackCommand.ExecuteCommand()
at NuGet.CommandLine.Command.ExecuteCommandAsync()
at NuGet.CommandLine.Command.Execute()
at NuGet.CommandLine.Program.MainCore(String workingDirectory, String[] args)
##[error]The nuget command failed with exit code(1) and error(The element 'metadata' in namespace 'http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd' has invalid child element 'readme' in namespace 'http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd'. List of possible elements expected: 'serviceable, dependencies, repository, licenseUrl, copyright, references, packageTypes, contentFiles, releaseNotes, tags, language, developmentDependency, frameworkAssemblies, owners' in namespace 'http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd'. This validation error occurred in a 'readme' element.)
##[error]An error occurred while trying to pack the files.
We'll have to update the Nuget version on the image first before we can remove the Nuget installer task.
There was a problem hiding this comment.
That's why I made this change: 71fb1b3
The NuGetCommand@2 task does not seem to use the NuGet we installed.
I didn't check if there is a way to tell to use the one we use.
| @@ -430,6 +455,10 @@ stages: | |||
| targetPath: '$(Build.SourcesDirectory)\build' | |||
| artifactName: build | |||
|
|
|||
| - task: NuGetToolInstaller@1 | |||
There was a problem hiding this comment.
Why this has been added?
It was not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1934
I have done some tests and was able to have a green CI for the Build stage.
To do so, I had to disable/comment on any task related to the SBOM file:
Dotnet generate SBOMtaskGenerate packagestask: I commented two lines in the scriptStage to repoxtask which needs the file to continueOnce the build of the dotnet-ci AMI is working, I do not expect to see any other issues, except maybe in the
Stage to repox.Update (from Zsolt): I re-enabled the tasks and modified the SBOM generation to make it work with the new image.