Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Java Creedengo plugin to 2.1.0 #651

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

dedece35
Copy link
Contributor

@dedece35 dedece35 commented Jan 8, 2025

Hi,

creedengo Java plugin 2.1.0 has been released.

Changes from last SonarQube marketplace integration (2.0.0), please check following changelogs :
https://github.com/green-code-initiative/creedengo-java/releases/tag/2.1.0

The corresponding SonarCloud project: https://sonarcloud.io/project/overview?id=green-code-initiative_creedengo-java

EDIT >> no longer relevant >> In the same PR, I revert publicVersion on ecocode-php and ecocode-python plugins as discussed with @ganncamp in PR #645

Thank you

Regards

David DE CARVALHO and others added 30 commits December 5, 2023 13:13
@dedece35 dedece35 changed the title Creedengo java 210 and old php python Upgrade Java Creedengo plugin to 2.1.0 and revert old ecocode-PHP and ecocode-python plugins Jan 8, 2025
@ganncamp
Copy link
Collaborator

Sorry @dedece35 but I don't read the commentary on that other PR the same way you do & I'm not comfortable updating 3 different plugins with one PR. My requirement that you change both the old and new versions of your language plugins at the same time was related directly to the deprecation/introduction you're doing. But on the face of it, these changes seem unrelated to each other

@dedece35 dedece35 changed the title Upgrade Java Creedengo plugin to 2.1.0 and revert old ecocode-PHP and ecocode-python plugins Upgrade Java Creedengo plugin to 2.1.0 Jan 10, 2025
@dedece35
Copy link
Contributor Author

dedece35 commented Jan 10, 2025

Sorry @dedece35 but I don't read the commentary on that other PR the same way you do & I'm not comfortable updating 3 different plugins with one PR. My requirement that you change both the old and new versions of your language plugins at the same time was related directly to the deprecation/introduction you're doing. But on the face of it, these changes seem unrelated to each other

I have just reverted PHP and Python plugin upgrades to only keep Java upgrade.
I also have modified PR title and PR description.

@@ -12,3 +12,9 @@ defaults.mavenArtifactId=creedengo-java-plugin
2.0.0.date=2024-12-18
2.0.0.downloadUrl=https://github.com/green-code-initiative/creedengo-java/releases/download/2.0.0/creedengo-java-plugin-2.0.0.jar
2.0.0.changelogUrl=https://github.com/green-code-initiative/creedengo-java/releases/tag/2.0.0

2.1.0.description=Add rule GCI82 and GCI94; Add support for SonarQube 24.12.0; improve library versions
2.1.0.sqVersions=[9.9,24.12.0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The valid sqVersions range ends at 10.7.
To also support 12.12, you'll add a separate sqcbVersions line.
Take a look here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants