Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOT NOT MERGE] Test to fix maven build error #1081

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SamirM-BE
Copy link
Contributor

For SonarSourcers:

  • Prefix the commit message with the ticket number, i.e. SLCORE-XXXX (or use NO-JIRA for a trivial change not tracked by a ticket)
  • When changing an API:
    • Explain in the JavaDoc the purpose of the new API
    • Document the change in API_CHANGES.md
    • If the change breaks the current API, explicitly communicate those to the impacted consumers prior to merging (eg. IDE squad)
  • Make sure the tests adhere to the convention:
    • All test method names should use snake_case, for example: test_validate_input.
  • Make sure checks are green: build passes, Quality Gate is green

For external contributors:

In addition to the above, please review our contribution guidelines and ensure your pull request adheres to the following guidelines:

  • Please explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Use the following formatting style: SonarSource/sonar-developer-toolset
  • Provide a unit test for any code you changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant