Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLCORE-937: Don't fail when checks not possible #1101

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

thahnen
Copy link
Member

@thahnen thahnen commented Sep 16, 2024

SLCORE-937

Skip the check for symbolic links and Windows shortcuts when filtering URIs for the analysis for protocols / schemes that are not supporting such operations.

If not skipping but excluding these URIs then using other protocols would never be possible.

Skip the check for symbolic links and Windows shortcuts when filtering URIs for the analysis for protocols / schemes that are not supporting such operations.

If not skipping but excluding these URIs then using other protocols would never be possible.
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thahnen thahnen merged commit dd5db3a into master Sep 16, 2024
14 checks passed
@thahnen thahnen deleted the fix/tha/SLCORE-937_OhNo branch September 16, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants