SLCORE-1029: Shade/relocate JGit into OSGi bundle #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for SonarLint for Eclipse to make use of the same JGit version as SonarLint CORE uses, we shade/relocate it into the OSGi bundle as well.
thahnen
force-pushed
the
fix/tha/SLCORE-1029_JGit
branch
from
868e1e5
to
a0f38ca
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLCORE-1029
Shading/relocating JGit (and its required dependency SLF4J) into the OSGi bundle in order to work properly on Eclipse again for the patch release 10.9.1 planned, see SonarSource/sonarlint-eclipse#761.
On SonarLint for Eclipse the incompatible dependency with EGit/JGit (bundled with the IDE, not from us, requiring Java 17 now) is dropped and replaced by this.
In order to satisfy the pipeline gods a test was fixed in a separate cherry-picked commit for ITs against SQ DEV.