Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLCORE-818 Provide connection parameters for SC while opening an issue in IDE #995

Merged
merged 1 commit into from
May 31, 2024
Merged

SLCORE-818 Provide connection parameters for SC while opening an issue in IDE #995

merged 1 commit into from
May 31, 2024

Conversation

serhat-yenican-sonarsource
Copy link
Contributor

@serhat-yenican-sonarsource serhat-yenican-sonarsource commented May 24, 2024 •
edited
Loading

For SonarSourcers:

  • Prefix the commit message with the ticket number, i.e. SLCORE-XXXX (or use NO-JIRA for a trivial change not tracked by a ticket)
  • When changing an API:
    • Explain in the JavaDoc the purpose of the new API
    • Document the change in API_CHANGES.md
    • If the change breaks the current API, explicitly communicate those to the impacted consumers prior to merging (eg. IDE squad)
  • Make sure the tests adhere to the convention:
    • All test method names should use snake_case, for example: test_validate_input.
  • Make sure checks are green: build passes, Quality Gate is green

For external contributors:

In addition to the above, please review our contribution guidelines and ensure your pull request adheres to the following guidelines:

  • Please explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Use the following formatting style: SonarSource/sonar-developer-toolset
  • Provide a unit test for any code you changed

@serhat-yenican-sonarsource serhat-yenican-sonarsource force-pushed the feature/serhat/SLCORE-818/provide-organization-key-for-sc-connection branch 3 times, most recently from 6c9bb31 to e7026ca Compare May 24, 2024 13:19
@serhat-yenican-sonarsource serhat-yenican-sonarsource marked this pull request as ready for review May 27, 2024 13:39
@serhat-yenican-sonarsource serhat-yenican-sonarsource force-pushed the feature/serhat/SLCORE-818/provide-organization-key-for-sc-connection branch from c03e64b to 07134ca Compare May 27, 2024 13:44
damien-urruty-sonarsource
damien-urruty-sonarsource reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@damien-urruty-sonarsource damien-urruty-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, I left a few comments. Let's discuss if needed

API_CHANGES.md Outdated Show resolved Hide resolved
backend/core/src/main/java/org/sonarsource/sonarlint/core/embedded/server/CorsFilter.java Outdated Show resolved Hide resolved
...onarsource/sonarlint/core/rpc/protocol/client/connection/AssistCreatingConnectionParams.java Outdated Show resolved Hide resolved
...re/src/main/java/org/sonarsource/sonarlint/core/embedded/server/ShowIssueRequestHandler.java Outdated Show resolved Hide resolved
...re/src/main/java/org/sonarsource/sonarlint/core/embedded/server/ShowIssueRequestHandler.java Outdated Show resolved Hide resolved
@serhat-yenican-sonarsource serhat-yenican-sonarsource force-pushed the feature/serhat/SLCORE-818/provide-organization-key-for-sc-connection branch 4 times, most recently from b3af88c to 73ba746 Compare May 29, 2024 11:11
@serhat-yenican-sonarsource serhat-yenican-sonarsource force-pushed the feature/serhat/SLCORE-818/provide-organization-key-for-sc-connection branch 2 times, most recently from 3bad037 to d289026 Compare May 29, 2024 15:05
@serhat-yenican-sonarsource serhat-yenican-sonarsource force-pushed the feature/serhat/SLCORE-818/provide-organization-key-for-sc-connection branch 5 times, most recently from 1c831ee to 0c8681b Compare May 29, 2024 16:54
damien-urruty-sonarsource
damien-urruty-sonarsource approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@damien-urruty-sonarsource damien-urruty-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, else LGTM!

API_CHANGES.md Outdated Show resolved Hide resolved
API_CHANGES.md Outdated Show resolved Hide resolved
...onarsource/sonarlint/core/rpc/protocol/client/connection/AssistCreatingConnectionParams.java Outdated Show resolved Hide resolved
@serhat-yenican-sonarsource serhat-yenican-sonarsource force-pushed the feature/serhat/SLCORE-818/provide-organization-key-for-sc-connection branch from 13dcabc to 09c77d5 Compare May 31, 2024 09:24
@serhat-yenican-sonarsource serhat-yenican-sonarsource force-pushed the feature/serhat/SLCORE-818/provide-organization-key-for-sc-connection branch from 09c77d5 to 8f2f04e Compare May 31, 2024 09:32
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
92.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@serhat-yenican-sonarsource serhat-yenican-sonarsource merged commit 34e5a83 into feature/SLCORE-804/open-issue-in-ide May 31, 2024
12 checks passed
@serhat-yenican-sonarsource serhat-yenican-sonarsource deleted the feature/serhat/SLCORE-818/provide-organization-key-for-sc-connection branch May 31, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damien-urruty-sonarsource damien-urruty-sonarsource damien-urruty-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhat-yenican-sonarsource @damien-urruty-sonarsource