Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLE-1065: Overhaul error notification #811

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

thahnen
Copy link
Member

@thahnen thahnen commented Feb 7, 2025

SLE-1065

When a user decide to ignore an error, also ignore "similar" errors. Also give the user the opportunity to not show any error notifications again.

Therefore the logging logic was overhauled (which I would have to do anyway for a proper error reporting mechanism that is planned to be implemented later).

@thahnen thahnen requested a review from nquinquenel February 10, 2025 15:55
@thahnen thahnen marked this pull request as ready for review February 10, 2025 15:55
});

addLink("Don't show again", e -> {
SonarLintGlobalConfiguration.setNoErrorNotifcation();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you unset this setting?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't from the UI 🤣 It is currently the case for nearly all of the global configurations, don't ask me why this was done this way for ever. I did not question this or why there was no "power user preference page" to change that. But for the latter one I have a ticket.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be changed tho of course by configuring it from the eclipse preference file. This is stored inside the Eclipse installation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HERE is the ticket I mean.

When user decide to ignore an error, also ignore "similar" errors.
Also give the user the opportunity to not show any error notifications again.
@thahnen thahnen force-pushed the fix/tha/SLE-1065_Errors branch from 17f045d to cbb7ad1 Compare February 12, 2025 11:30
@thahnen thahnen requested a review from nquinquenel February 12, 2025 12:15
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thahnen thahnen merged commit d6f3561 into master Feb 12, 2025
20 checks passed
@thahnen thahnen deleted the fix/tha/SLE-1065_Errors branch February 12, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants