-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLE-1065: Overhaul error notification #811
Conversation
org.sonarlint.eclipse.ui/src/org/sonarlint/eclipse/ui/internal/popup/ErrorPopup.java
Show resolved
Hide resolved
...e.core/src/org/sonarlint/eclipse/core/internal/preferences/SonarLintGlobalConfiguration.java
Outdated
Show resolved
Hide resolved
...e.core/src/org/sonarlint/eclipse/core/internal/preferences/SonarLintGlobalConfiguration.java
Show resolved
Hide resolved
}); | ||
|
||
addLink("Don't show again", e -> { | ||
SonarLintGlobalConfiguration.setNoErrorNotifcation(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you unset this setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't from the UI 🤣 It is currently the case for nearly all of the global configurations, don't ask me why this was done this way for ever. I did not question this or why there was no "power user preference page" to change that. But for the latter one I have a ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be changed tho of course by configuring it from the eclipse preference file. This is stored inside the Eclipse installation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HERE is the ticket I mean.
When user decide to ignore an error, also ignore "similar" errors. Also give the user the opportunity to not show any error notifications again.
17f045d
to
cbb7ad1
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SLE-1065
When a user decide to ignore an error, also ignore "similar" errors. Also give the user the opportunity to not show any error notifications again.
Therefore the logging logic was overhauled (which I would have to do anyway for a proper error reporting mechanism that is planned to be implemented later).