-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQSCANGHA-76 Support self-hosted runners not clearing truststore after run #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonioaversa
force-pushed
the
antonio/SQSCANGHA-76-clear-truststore
branch
5 times, most recently
from
December 16, 2024 09:07
13624c6
to
756903a
Compare
antonioaversa
commented
Dec 16, 2024
antonioaversa
force-pushed
the
antonio/SQSCANGHA-75-clear-runner-temp
branch
from
December 16, 2024 09:41
3ee5ee7
to
0d06820
Compare
Base automatically changed from
antonio/SQSCANGHA-75-clear-runner-temp
to
master
December 16, 2024 09:45
antonioaversa
force-pushed
the
antonio/SQSCANGHA-76-clear-truststore
branch
from
December 16, 2024 09:47
756903a
to
4d448d0
Compare
antonioaversa
force-pushed
the
antonio/SQSCANGHA-76-clear-truststore
branch
2 times, most recently
from
December 16, 2024 14:16
8834ec6
to
111a640
Compare
henryju
reviewed
Dec 16, 2024
antonioaversa
force-pushed
the
antonio/SQSCANGHA-76-clear-truststore
branch
from
December 16, 2024 14:39
111a640
to
bb88be4
Compare
…g the entire folder
antonioaversa
force-pushed
the
antonio/SQSCANGHA-76-clear-truststore
branch
from
December 16, 2024 14:42
bb88be4
to
839486e
Compare
antonioaversa
force-pushed
the
antonio/SQSCANGHA-76-clear-truststore
branch
4 times, most recently
from
December 16, 2024 15:16
1ca746e
to
d5f7c21
Compare
antonioaversa
force-pushed
the
antonio/SQSCANGHA-76-clear-truststore
branch
from
December 16, 2024 15:19
d5f7c21
to
3f42147
Compare
henryju
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, congrats for the test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kept in draft to avoid accidental merging into #165.Originated from this discuss post.
Similar scenario as #164 (self-hosted Github runners), but for SSL certificates:
The warning appears like hereUpdate: change of behavior
Now, if the
truststore.p12
exists already, we don't remove anymore the~/sonar/ssl
directory.Instead, we check whether such
truststore.p12
contains asonar
alias.If it does, and only if it does, we remove the alias from the truststore, and then we proceed as usual.
If people really want to start with a clean truststore.p12, they can tune their agent.
Here is a successful run: https://github.com/SonarSource/sonarqube-scan-action/actions/runs/12355702818/job/34479954427?pr=165