Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-403 Update links in the README.md file to the documentation #167

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

PrzemekMoskal
Copy link
Contributor

Updating links to the documentation.

Reference Jira ticket: https://sonarsource.atlassian.net/browse/DOC-403

Some of the links in the code samples are from pre-rebrand time and need to be updated.
The current links work because of the redirects but it's better to update them as they are visible in the code samples.

Updating links to the documentation.
@antonioaversa antonioaversa self-requested a review January 8, 2025 08:50
@antonioaversa antonioaversa changed the title Update links in the README.md file to the documentation DOC-403 Update links in the README.md file to the documentation Jan 8, 2025
Copy link
Contributor

@antonioaversa antonioaversa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the broken links!
I think there were two issues with those links: they were never updated, and also pointing to the wrong page. I suggested the right links.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@antonioaversa antonioaversa self-requested a review January 8, 2025 14:19
Copy link
Contributor

@antonioaversa antonioaversa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed the two comments on the links, so the PR is now ready to be merged.

@antonioaversa antonioaversa merged commit d6b87b0 into SonarSource:master Jan 8, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants