-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #294: Better mobile experience #367
base: master
Are you sure you want to change the base?
Conversation
That's promising! Could you add some screenshots for both web and mobile, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, after a quick review. Overall seems ok.
I've made some changes since the creation of the repository but you can preview some screenshots there: I didn't find the existing screenshots of the project but sure I can add some. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tab issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tabs replaced by spaces
@lGuillaume124 For me it seems all good. I actually prefer the player on the bottom since it follows the industry standard and definitely makes more sense on mobile. @skw4y From the mobile screenshot, I don't see these buttons: Is it possible to access them somehow, or they're completely hidden when on mobile? |
@MightyCreak On mobile the shuffle button is visible but the other two are completely hidden for the moment: |
The screenshots on your changes seem a bit outdated (for instance the play controls are now on the bottom right, it is on the bottom left in your screenshots). Could you just refresh the ones from your changes? The interface here on master didn't change that much (though a discussion is in progress). |
Yes sure, I was pointing the one in my repository just to give you an idea but I'll refresh them tonight. |
Thank you! Much appreciated 😉 |
I've just updated the screenshots on my sonerezh-mobile repo but I can also add them to the current pull request if you want. |
Thanks! If you could add them in the PR description, that would be awesome (the more descriptive a PR is, the more probable it will be merged, because it's easier to get in and review since we know what to expect). But the final word will be for @lGuillaume124 anyway 😉 |
Some Sonerezh theme hacks for a better mobile experience :
Desktop Preview
Mobile Preview