Adding back Support for Keychron K3 v2 to sn32_develop #437
Conversation
|
Hello, I would like to port Keychron K6 support from old branch. Are there any reminders/instructions to follow? Or is it as simple as copying old code and paste them to the develop branch? |
You can find infos about how to add back support in this issue #420 |
| */ | ||
| [MAC_FN] = LAYOUT_75_iso( | ||
| /* 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 */ | ||
| _______, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10, KC_F11, KC_F12, QK_BOOT, _______, RGB_M_P , |
There was a problem hiding this comment.
small suggestion. From the docs the convention for QK_BOOT seems to to be Fn+Esc. This changes this which will likely confuse users that didn't bother reading the keymap thoroughly. I would propose to move it back to the the Esc key again.
|
@macaholik Thanks for picking this up. I've flashed the |
| _______, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10, KC_F11, KC_F12, QK_BOOT, _______, RGB_M_P , | ||
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______ , | ||
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______ , | ||
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______ , | ||
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, RGB_SAI, _______ , | ||
| _______, _______, _______, _______, _______, _______, _______, RGB_HUD, RGB_SAD, RGB_HUI |
There was a problem hiding this comment.
Many of the RGB_* keycode have been deprecated since May so this would be a good time to update them.
| "console": false, | ||
| "extrakey": true, | ||
| "mousekey": false, | ||
| "nkro": true, |
There was a problem hiding this comment.
NKRO doesn't seem to be enabled by default afaict. Is this supposed to do that?
Description
Added back support for Keychron K3 v2 ISO from the sn32_master branch
Types of Changes
Issues Fixed or Closed by This PR
Checklist