Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle UNSELECT_DRIVE_HIGH and SN32F2XX_PWM_OUTPUT_ACTIVE_HIGH #441

Open
wants to merge 2 commits into
base: sn32_develop
Choose a base branch
from

Conversation

iglooom
Copy link

@iglooom iglooom commented Jan 23, 2025

Description

I've tried to update qmk firmware on my FL980 keyboard, and the latest sn32_develop is now broken since I added this keyboard a couple of years ago.
RGB works fine, but the keys do not.
I was able to pinpoint this commit .
This keyboard has odd schematics and works like this:

  • Disable PWM
  • Drive Cols High
  • Scan matrix
  • Drive Cols Low
  • Enable PWM
  • Enable RGB by driving Cols High as RGB_OUTPUT_ACTIVE_HIGH

matrix

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 23, 2025
@dexter93
Copy link

dexter93 commented Feb 3, 2025

That particular bit was removed because it was introducing RGB artifacts in certain configs. The board you're working with is unusual - looks like the proper way to tackle it is flipping SN32_PWM_DIRECTION. Could you try that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants