Add semigroup superclass when available from base #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't necessarily want to import semigroups and take in all of those dependencies, so I use a bit of CPP around the base version in which Data.Semigroup appeared and set up the superclass in that case. This is for #53
|
Seems reasonable to me! |
|
This is released with retry 0.7.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't necessarily want to import semigroups and take in all of those
dependencies, so I use a bit of CPP around the base version in which
Data.Semigroup appeared and set up the superclass in that case.
This is for #53
@mithrandi @ozataman let me know if you have any particular opinions here, otherwise I'll merge it. The short explanation is this adds no new dependencies because it doesn't target
semigroupsbut rather provides an instance forSemigroupif you have a recent enough base that its available.