explicitly import forM_ in test; fix tests on GHC 9.6 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My GHC 9.2.7 emits an unused import message for |
|
Looks like |
MichaelXavier
added a commit
that referenced
this pull request
Apr 17, 2023
This resolves #82. The code in that MR worked but it produced warnings in the current default lts for the project. I used the qualified import trick to resolve the warning. Then the partial matches started failing in newer GHC versions so I resolved that too. This now builds without warnings on the project LTS, the newest LTS and nightly.
Merged
|
Thanks for this MR. I ended up solving it slightly differently to resolve warnings in different GHC versions. It has been released as retry-0.9.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are broken on GHC 9.6 due to an unscoped
forM_usage. It used to be exported byData.Foldable, and does appear to be present from there on GHC 9.2.7. I can't see whereData.Foldableis imported -- I assume it's re-exported by one of the imports, but I can't tell which.