Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes and new feature #73

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

allanmcarvalho
Copy link

  • Fix a problem that delete all filepond dir when removing a chunked upload.

  • Add a garbage collector feature that run based in a percent probability deleting old unsed files from filepond folder.

- Fix a problem that delete all filepond dir when removing a chunked upload.

- Add a garbage collector feature that run based in a percent probability deleting old unsed files from filepond folder.
@allanmcarvalho
Copy link
Author

allanmcarvalho commented Jul 3, 2023

More details:
When delete method of controller is called, dirname function previous was deleting the whole filepond folder for chunked files uploads. Now the method check if the folder path to be deleted is the same of filepond, so it presume that the target file is a chucked file. On this behavior we get the file folder id and delete it on chunk folder (if exists) and the file. For standard uploads nothing diferent is done.

In garbage collector the method doGarbageCollector in controller is called in upload start when the percentage of chance is hit. It check if that upload is older than the limit and then delete the file and its folders.

@Sopamo
Copy link
Owner

Sopamo commented Jul 3, 2023

Thanks for your contribution! I'm currently on vacation, but I will have a look at your PR once I'm back.

@zulfikar-ditya
Copy link

@Sopamo Any updates? or you are still in your vocation

@2btechdev2
Copy link

I think He is on permanent vacation.
I am forking this and publishing this package. Along with Opened PR Merged. (Copy Pastin code 😁)

@zulfikar-ditya @allanmcarvalho

@2btechdev2
Copy link

@zulfikar-ditya
Copy link

@2btechdev2 There is nothing we can do. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants