Skip to content

Commit

Permalink
[apache#4506] fix(UI): Hide jdbc-password value in details page (apac…
Browse files Browse the repository at this point in the history
…he#4561)

### What changes were proposed in this pull request?

Hide jdbc-password value in details page.

### Why are the changes needed?

Fix: apache#4506 

### Does this PR introduce _any_ user-facing change?

Jdbc-password value is not palintext now.

### How was this patch tested?

![Screenshot from 2024-08-16
15-31-53](https://github.com/user-attachments/assets/75cb2a83-8145-41be-9be5-19a7a4add336)
![Screenshot from 2024-08-16
15-21-04](https://github.com/user-attachments/assets/63e34fee-fef1-4fa6-a93c-ac028b2d04b3)
  • Loading branch information
featherchen authored Aug 19, 2024
1 parent 7e61d0d commit 5ccdb31
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ const DetailsView = () => {
: `props-value-${item.key}`
}
>
{item.value}
{item.key === 'jdbc-password' ? '[HIDDEN]' : item.value}
</div>
</Typography>
</TableCell>
Expand Down
2 changes: 1 addition & 1 deletion web/src/components/DetailsDrawer.js
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ const DetailsDrawer = props => {
data-refer={`details-props-value-${item.value}`}
data-prev-refer={`details-props-key-${item.key}`}
>
{item.value}
{item.key === 'jdbc-password' ? '[HIDDEN]' : item.value}
</TableCell>
</TableRow>
)
Expand Down

0 comments on commit 5ccdb31

Please sign in to comment.