Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated visualizers and mainpage using KIVY GUI #153

Merged
merged 5 commits into from
Jun 30, 2024

Conversation

Priyaanshucodez
Copy link
Contributor

@Priyaanshucodez Priyaanshucodez commented Jun 24, 2024

ma'am you can check the file now #133 ....if in case of any discrepancies ..plz tell me ..I will resolve it

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Priyaanshucodez! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add an screenshot of the final output since there are a decent lot changes

@Priyaanshucodez
Copy link
Contributor Author

yes sure ... I have actually modified the 4 main visualizers using KivyGUI as an Alternative to PySimpleGUI giving the same output as the previous code.

Screenshot (54)
Screenshot (53)
Screenshot (52)
Screenshot (50)

@Priyaanshucodez
Copy link
Contributor Author

used it as an alternative since PySimpleGUI was not working from the user end referred to issue #133

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot can be improved in terms of the UI starting from the buttons, colors and window of course also fixing text overflowing buttons, improving UI and making it near for mic to sound intensity. looks good to merge otherwise.

@Priyaanshucodez
Copy link
Contributor Author

Priyaanshucodez commented Jun 29, 2024

@dinxsh I know Sir but since I had to follow the code of conduct of gssoc ...So I worked according to the issue and just updated the code with new GUI framework instead of improving it further ...Actually Gssoc is my first open source program so I was really cautious :) .

@dinxsh
Copy link
Collaborator

dinxsh commented Jun 29, 2024

@dinxsh I know Sir but since I had to follow the code of conduct of gssoc ...So I worked according to the issue and just updated the code with new GUI framework instead of improving it further ...Actually Gssoc is my first open source program so I was really cautious :) .

its a good contribution for sure just make these small fixes like text overflowing buttons, and making mic to sound intensity clear and neat (over the buttons section) we'll be sure to merge it for you @Priyaanshucodez

you can dm on discord for further help at dinxsh

@Priyaanshucodez
Copy link
Contributor Author

Priyaanshucodez commented Jun 30, 2024

thank you so much @dinxsh sir for the complement but I had a request can i please take these small fixes as a new level 1 issue ...Actually this is my first decent contribution as i couldn't contribute to gssoc before due to college examinations so if you feel its decent enough to merge can you do it from your side ?

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, looking forward to more updates for this

@dinxsh dinxsh merged commit 6b965e4 into Soumya-Kushwaha:main Jun 30, 2024
3 checks passed
@Priyaanshucodez
Copy link
Contributor Author

looks good to me, looking forward to more updates for this

Sure Sir 👍

@dinxsh
Copy link
Collaborator

dinxsh commented Jun 30, 2024

do create issues to fix these asap to avoid new confusion for new contributors and ping me in those @Priyaanshucodez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants