Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major cleanup of testing & documentation #144

Closed
wants to merge 15 commits into from
Closed

Major cleanup of testing & documentation #144

wants to merge 15 commits into from

Conversation

detjensrobert
Copy link
Contributor

@detjensrobert detjensrobert commented Sep 9, 2020

Description

  • Adds full InSpec testing for Kitchen suite
  • Adds complete documentation for resources
  • Refactors ChefSpec tests for full coverage
  • Refactors test recipes and suites
  • Idempotency fixes for test recipes
  • Updates old conventions to modern standards

Breaking Changes

  • Removed support for:
    • Amazon Linux
    • Amazon Linux 2
    • Debian
    • Ubuntu

Issues Resolved

Fixes #123 #121

Check List


Signed-off-by: Robert Detjens [email protected]

@detjensrobert
Copy link
Contributor Author

SELinux testing does not work with Dokken / Docker and breaks GHCI due to a reboot needed to fully enable SEL. Should the GHCI Dokken testing be removed or disabled?

@ramereth
Copy link
Contributor

ramereth commented Sep 9, 2020

SELinux testing does not work with Dokken / Docker and breaks GHCI due to a reboot needed to fully enable SEL. Should the GHCI Dokken testing be removed or disabled?

The only way to do this is via some runner which supports Virtualbox+Vagrant. Unfortunately GH Actions don't support nested virtualization yet so that's not really an option. The other option is doing this from a self hosted runner but I doubt Chef Inc would want to do that.

Perhaps the best option is to just remove the dokken ci portion of this and also remove the dokken yaml in the meantime and force use of Vagrant? I'd want to see what @tas50 thinks however.

documentation/resource_install.md Outdated Show resolved Hide resolved
resources/boolean.rb Outdated Show resolved Hide resolved
kitchen.yml Show resolved Hide resolved
Copy link
Contributor

@ramereth ramereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramereth ramereth deleted the branch Sous-Chefs-Boneyard:master August 31, 2021 04:44
@ramereth ramereth closed this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Run latest cookstyle
2 participants