-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major cleanup of testing & documentation #144
Major cleanup of testing & documentation #144
Conversation
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
SELinux testing does not work with Dokken / Docker and breaks GHCI due to a reboot needed to fully enable SEL. Should the GHCI Dokken testing be removed or disabled? |
The only way to do this is via some runner which supports Virtualbox+Vagrant. Unfortunately GH Actions don't support nested virtualization yet so that's not really an option. The other option is doing this from a self hosted runner but I doubt Chef Inc would want to do that. Perhaps the best option is to just remove the dokken ci portion of this and also remove the dokken yaml in the meantime and force use of Vagrant? I'd want to see what @tas50 thinks however. |
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Breaking Changes
Issues Resolved
Fixes #123 #121
Check List
Signed-off-by: Robert Detjens [email protected]