Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add image import functionality #24

Closed
wants to merge 4 commits into from

Conversation

michal-gubricky
Copy link
Contributor

@michal-gubricky michal-gubricky commented Dec 21, 2023

What this PR does / why we need it:
Add image import functionality

Needs to be tested...

@michal-gubricky michal-gubricky self-assigned this Dec 21, 2023
@cluster-stack-bot cluster-stack-bot bot added the size/XXL Denotes a PR that changes 2000+ lines, ignoring generated files. label Dec 21, 2023
@NotTheEvilOne NotTheEvilOne changed the title ✨ Addd image import functionality ✨ Add image import functionality Dec 21, 2023
@NotTheEvilOne NotTheEvilOne self-requested a review December 21, 2023 19:38
Copy link
Contributor

@NotTheEvilOne NotTheEvilOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michal-gubricky,

I added some minor changes, hope that's fine for you as the code was not marked as "WIP".

@michal-gubricky
Copy link
Contributor Author

Hi @michal-gubricky,

I added some minor changes, hope that's fine for you as the code was not marked as "WIP".

Hi @NotTheEvilOne,

it was just the first working iteration of the code, which was published at the end of the day. So some kind of "WIP", that's why I haven't assigned anyone as a reviewer yet.

But I appreciate your changes in the code. I will take a look at them and test them. Thank you.

@michal-gubricky michal-gubricky added the work in progress Pull requests that are work in progress, do not merge them label Dec 22, 2023
@michal-gubricky michal-gubricky marked this pull request as draft December 22, 2023 14:26
@matofeder
Copy link
Member

re-implemented in #27

@matofeder matofeder closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 2000+ lines, ignoring generated files. work in progress Pull requests that are work in progress, do not merge them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants