-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cluster-class): options from different api versions somehow mixed up #131
Conversation
Signed-off-by: Jan Schoone <[email protected]>
Build failed (e2e-quick-test pipeline). ❌ e2e-openstack-quick FAILURE in 4m 16s |
Build failed (e2e-quick-test pipeline). ❌ e2e-openstack-quick FAILURE in 41m 56s |
Hi @chess-knight and @DEiselt could you have a look if theres something left and/or I made something wrong? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have only one small finding so far.
providers/openstack/scs/cluster-class/templates/cluster-class.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from @chess-knight's comment
Build failed (e2e-quick-test pipeline). ❌ e2e-openstack-quick FAILURE in 10m 44s |
Build failed (e2e-quick-test pipeline). ❌ e2e-openstack-quick FAILURE in 10m 53s |
Ah, based on the last run, it seems the infrastructure running the Zuul tests is slow, as it takes over 3 minutes for pods in the kube-system to be ready in the kind cluster that is usually not a problem. I will try to run this pipeline later today. |
Based on this failed pipeline and further investigation, we need to adjust the e2e tests, as the structure of this repository has changed. I will create an issue and start working on that. |
@jschoone it looks like @michal-gubricky and i found the issue with the e2e tests. I will merge this PR now. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #129
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: