Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cluster-class): options from different api versions somehow mixed up #131

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

jschoone
Copy link
Contributor

@jschoone jschoone commented Jul 4, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #129

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests
cluster_stack = "providers/openstack/scs"

@scs-zuul
Copy link

scs-zuul bot commented Jul 5, 2024

Build failed (e2e-quick-test pipeline).
https://zuul.scs.community/t/SCS/buildset/93f5c618417d4db79918c6e74469d9d3

e2e-openstack-quick FAILURE in 4m 16s

@scs-zuul
Copy link

scs-zuul bot commented Jul 5, 2024

Build failed (e2e-quick-test pipeline).
https://zuul.scs.community/t/SCS/buildset/468aceff46cc4c21a75a820ca9fdc681

e2e-openstack-quick FAILURE in 41m 56s

@jschoone
Copy link
Contributor Author

jschoone commented Jul 8, 2024

Hi @chess-knight and @DEiselt could you have a look if theres something left and/or I made something wrong?
My first tests worked so far

Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have only one small finding so far.

Copy link
Contributor

@DEiselt DEiselt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from @chess-knight's comment

@scs-zuul
Copy link

scs-zuul bot commented Jul 9, 2024

Build failed (e2e-quick-test pipeline).
https://zuul.scs.community/t/SCS/buildset/96488be537f04f3da611c6caebe431a6

e2e-openstack-quick FAILURE in 10m 44s

@scs-zuul
Copy link

scs-zuul bot commented Jul 9, 2024

Build failed (e2e-quick-test pipeline).
https://zuul.scs.community/t/SCS/buildset/e1ab5fb1ad3840f29feba4097a6c968b

e2e-openstack-quick FAILURE in 10m 53s

@michal-gubricky
Copy link
Contributor

Build failed (e2e-quick-test pipeline). https://zuul.scs.community/t/SCS/buildset/e1ab5fb1ad3840f29feba4097a6c968b

e2e-openstack-quick FAILURE in 10m 53s

Ah, based on the last run, it seems the infrastructure running the Zuul tests is slow, as it takes over 3 minutes for pods in the kube-system to be ready in the kind cluster that is usually not a problem. I will try to run this pipeline later today.

@michal-gubricky
Copy link
Contributor

Build failed (e2e-quick-test pipeline). https://zuul.scs.community/t/SCS/buildset/468aceff46cc4c21a75a820ca9fdc681

e2e-openstack-quick FAILURE in 41m 56s

Based on this failed pipeline and further investigation, we need to adjust the e2e tests, as the structure of this repository has changed. I will create an issue and start working on that.

@DEiselt
Copy link
Contributor

DEiselt commented Jul 10, 2024

@jschoone it looks like @michal-gubricky and i found the issue with the e2e tests. I will merge this PR now.

@DEiselt DEiselt merged commit 6b25021 into main Jul 10, 2024
2 checks passed
@DEiselt DEiselt deleted the fix/v1alpha7_v1beta1_mixup branch July 10, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes from v1alpha7 to v1beta1 not present in openstack-scs Cluster Stacks
4 participants