Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Manage Security Groups using OpenStackClusterTemplate #138

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

michal-gubricky
Copy link
Contributor

@michal-gubricky michal-gubricky commented Jul 11, 2024

What this PR does / why we need it:
This PR adds security rules for the Cilium into the default security groups for control-plane and worker nodes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #74

Special notes for your reviewer:
This is how security groups for control-plane and worker nodes look like now:
sec-group-contorlplane
sec-groups-worker

Signed-off-by: michal.gubricky <[email protected]>
@michal-gubricky michal-gubricky marked this pull request as ready for review July 11, 2024 12:27
Copy link
Contributor

@DEiselt DEiselt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, i am unfortunately unable to test this due to issues with the infrastructure providers i have access to.

Copy link
Contributor

@DEiselt DEiselt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to test now.

Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michal-gubricky michal-gubricky merged commit a516c90 into main Jul 19, 2024
2 checks passed
@michal-gubricky michal-gubricky deleted the feat/sec-groups branch July 19, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage Security Groups using OpenStackClusterTemplate
3 participants