Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add checkout to PR banch into e2e tests #145

Merged
merged 6 commits into from
Aug 8, 2024
Merged

🐛 Add checkout to PR banch into e2e tests #145

merged 6 commits into from
Aug 8, 2024

Conversation

michal-gubricky
Copy link
Contributor

What this PR does / why we need it:
This PR adds checkout to the PR branch into e2e tests and fix the same problem we had in the KaaS v1 repo.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #134 (comment)

@michal-gubricky michal-gubricky added Container Issues or pull requests relevant for Team 2: Container Infra and Tooling e2e-quick-test labels Jul 22, 2024
@scs-zuul
Copy link

scs-zuul bot commented Jul 22, 2024

Build failed (e2e-quick-test pipeline).
https://zuul.scs.community/t/SCS/buildset/6db7b9f794b0492598f8598b157f98d6

❌ e2e-openstack-quick FAILURE in 4m 05s

@michal-gubricky michal-gubricky force-pushed the feat/checkout-pr-branch branch from 2850215 to 446fda9 Compare July 22, 2024 09:49
@michal-gubricky michal-gubricky force-pushed the feat/checkout-pr-branch branch from 446fda9 to f7e00f8 Compare July 22, 2024 09:52
@scs-zuul scs-zuul bot removed the e2e-quick-test label Jul 22, 2024
@scs-zuul
Copy link

scs-zuul bot commented Jul 22, 2024

Build failed (e2e-quick-test pipeline).
https://zuul.scs.community/t/SCS/buildset/d06ae5bd96be4f2f8a92aad448565af9

❌ e2e-openstack-quick FAILURE in 5m 45s

@michal-gubricky
Copy link
Contributor Author

We need to wait until this #134 will be merged.

@scs-zuul scs-zuul bot removed the e2e-quick-test label Jul 23, 2024
@scs-zuul
Copy link

scs-zuul bot commented Jul 23, 2024

Build failed (e2e-quick-test pipeline).
https://zuul.scs.community/t/SCS/buildset/e39234901f4c4c79846711b961af951e

❌ e2e-openstack-quick FAILURE in 36m 39s

@scs-zuul scs-zuul bot removed the e2e-quick-test label Jul 23, 2024
@scs-zuul
Copy link

scs-zuul bot commented Jul 23, 2024

Build failed (e2e-quick-test pipeline).
https://zuul.scs.community/t/SCS/buildset/6e1ad3ce6a8c45cbbdbb973d4b7a8959

❌ e2e-openstack-quick FAILURE in 46m 22s

chess-knight
chess-knight approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chess-knight chess-knight merged commit 751ea2d into main Aug 8, 2024
3 checks passed
@chess-knight chess-knight deleted the feat/checkout-pr-branch branch August 8, 2024 12:54
@scs-zuul
Copy link

scs-zuul bot commented Nov 8, 2024

Unable to freeze job graph: Pre-review pipeline e2e-quick-test does not allow post-review job e2e-openstack-quick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chess-knight chess-knight chess-knight approved these changes

Assignees

@chess-knight chess-knight

@michal-gubricky michal-gubricky

Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling failed-e2e-quick-test
Projects
Sovereign Cloud Stack
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michal-gubricky @chess-knight @jschoone