Add support to change behaviour based on feature flags

This commit supports feature flags for:
- Ceph
- Kubernetes
- Rook

As we do not have feature flags for Ceph or Kubernetes yet any key is currently accepted. This will change once needed.

Signed-off-by: Tobias Wolf <[email protected]>

config.example.osism.yaml

@@ -39,6 +39,8 @@ rook:
     rgw_placement_label: node-role.osism.tech/rook-rgw
   ceph:
     image: quay.io/ceph/ceph:v18.2.1
+  flags:
+    mds_support_metadata_name: False
 
 migration_modules:
 - example

config.example.yaml

@@ -40,6 +40,8 @@ rook:
     namespace: rook-ceph
   ceph:
     image: quay.io/ceph/ceph:v18.2.1
+  flags:
+    mds_support_metadata_name: False
 
 migration_modules:
 - example
@@ -48,5 +50,6 @@ migration_modules:
 - migrate_osd_pools
 - migrate_mds
 - migrate_mds_pools
+- migrate_mgrs
 - migrate_rgws
 - migrate_rgw_pools

src/rookify/config.schema.yaml

@@ -9,6 +9,7 @@ logging:
 
 ceph:
   config: str()
+  flags: map(key=str(), required=False) # @TODO: Replace with include once we support at least one Ceph flag
   keyring: str()
   systemd_file_name_templates: include("systemd_file_name_templates", required=False)
 
@@ -18,6 +19,7 @@ ssh:
 
 kubernetes:
   config: str()
+  flags: map(key=str(), required=False) # @TODO: Replace with include once we support at least one Kubernetes flag
 
 rook:
   cluster:
@@ -34,9 +36,13 @@ rook:
     image: str()
     public_network: regex("^((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)(/(3[0-2]|2[0-9]|1[0-9]|[0-9]))?$", required=False)
     cluster_network: regex("^((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)(/(3[0-2]|2[0-9]|1[0-9]|[0-9]))?$", required=False)
+  flags: include("rook_flags", required=False)
 
 migration_modules: list(str())
 ---
+rook_flags:
+    mds_support_metadata_name: bool()
+---
 ssh_host:
     address: ip()
     user: str()

src/rookify/modules/ceph.py

@@ -18,6 +18,7 @@ def __init__(self, config: Dict[str, Any]):
 
         status_data = self.mon_command("status")
 
+        self._flags: Dict[str, bool] = config.get("flags", {})
         self._fsid = status_data["fsid"]
 
         self._systemd_file_name_templates = config.get(
@@ -40,6 +41,9 @@ def _json_command(self, handler: Any, *args: Any) -> Any:
 
         return data
 
+    def get_flag(self, name: str, default_value: bool = False) -> bool:
+        return self._flags.get(name, default_value)
+
     def get_systemd_mds_file_name(self, host: str) -> str:
         return self._get_systemd_template_file_name(
             self._systemd_file_name_templates.get("mds", "ceph-mds.target"),

src/rookify/modules/k8s.py

@@ -11,7 +11,9 @@ def __init__(self, config: Dict[str, Any]):
             config_file=config["kubernetes"]["config"]
         )
 
+        self._flags: Dict[str, bool] = config["kubernetes"].get("flags", {})
         self._rook_config = config["rook"]
+        self._rook_flags: Dict[str, bool] = config["rook"].get("flags", {})
 
         self.__client = kubernetes.client.ApiClient(k8s_config)
         self.__dynamic_client: Optional[kubernetes.dynamic.DynamicClient] = None
@@ -116,6 +118,17 @@ def crd_api_apply(
         except kubernetes.dynamic.exceptions.NotFoundError:
             return crd_api.create(body=manifest, namespace=namespace)
 
+    def _get_flag(
+        self, flags: Dict[str, bool], name: str, default_value: bool = False
+    ) -> bool:
+        return flags.get(name, default_value)
+
+    def get_flag(self, name: str, default_value: bool = False) -> bool:
+        return self._get_flag(self._flags, name, default_value)
+
+    def get_rook_flag(self, name: str, default_value: bool = False) -> bool:
+        return self._get_flag(self._rook_flags, name, default_value)
+
     def watch_events(
         self,
         callback_func: Callable[[Any], Any],