-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/containerize application #24
Conversation
23ef34e
to
62e3ae1
Compare
62a3f3f
to
1f5572c
Compare
1f5572c
to
248d6b5
Compare
ok in the last commit I just added I changed some bigger things (please review):
|
cf9375f
to
b28c22e
Compare
Dockerfile to manually install python3-rados when version is correct Signed-off-by: R.A. te Boekhorst <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: R.A. te Boekhorst <[email protected]>
…o pyproject.toml, adapt Makefile and remove unnecessary methods and also add more clear tag Signed-off-by: R.A. te Boekhorst <[email protected]>
…efile Signed-off-by: Rafael te Boekhorst <[email protected]>
b28c22e
to
4c0f64e
Compare
ok so set the tag differently in the makefile as requested. |
ok tested some more. Interestingly enough, the build works fine, but running rookify in the container does not work, because it cannot find rados for python 3.9. |
Since we're having a little bit of an chicken-egg-problem by either using the official ceph container image or the official python image we've decided to (try to) target Pros:
Cons:
|
I've now updated |
8ff6b76
to
ef78db2
Compare
Signed-off-by: Tobias Wolf <[email protected]>
ef78db2
to
723a972
Compare
Signed-off-by: Tobias Wolf <[email protected]>
5a5c958
to
7e6027b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a sane approach now from my side.
Not sure if this already makes sense, but now that we have the container image we can already mention it in the README.
Also, if I just build it and start it, in complains about a missing config.yaml
and there is no hint on how to create one.
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Jan-Marten Brüggemann <[email protected]>
NOTE: this is currently dependent on #23
ISSUE:
Closes: #2