Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes for build and workflow code #48

Merged
merged 3 commits into from
May 31, 2024
Merged

Various fixes for build and workflow code #48

merged 3 commits into from
May 31, 2024

Conversation

NotTheEvilOne
Copy link
Contributor

During development multiple issues showed up that are fixed with this PR:

  • The template path used for each module was constructed in a wrong way leading to No such file or directory errors
  • States are scheduled multiple times even if already added to transitions
  • A warning is displayed while building Python packages because optional-dependencies are not marked as dynamic in pyproject.toml

@NotTheEvilOne NotTheEvilOne added bug Something isn't working framework Core components of rookify labels May 31, 2024
@NotTheEvilOne NotTheEvilOne self-assigned this May 31, 2024
@NotTheEvilOne NotTheEvilOne force-pushed the fixes/various-fixes branch from c5c1564 to d7deaba Compare May 31, 2024 06:38
@NotTheEvilOne NotTheEvilOne merged commit 0e32bed into main May 31, 2024
1 of 2 checks passed
@NotTheEvilOne NotTheEvilOne deleted the fixes/various-fixes branch May 31, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boekhorstb1 boekhorstb1 boekhorstb1 approved these changes

@brueggemann brueggemann Awaiting requested review from brueggemann

Assignees

@NotTheEvilOne NotTheEvilOne

Labels
bug Something isn't working framework Core components of rookify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotTheEvilOne @boekhorstb1