Externalize ModuleHandler subclasses
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Marten Brüggemann <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Jan-Marten Brüggemann <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
NotTheEvilOne
added
the
work in progress
NotTheEvilOne
force-pushed
the
prs/externalize-modulehandler-subclasses
branch
from
e4d24aa to
059c765
Compare
NotTheEvilOne
added
enhancement
Signed-off-by: Tobias Wolf <[email protected]>
NotTheEvilOne
force-pushed
the
prs/externalize-modulehandler-subclasses
branch
from
059c765 to
4dcc214
Compare
boekhorstb1
approved these changes
Jun 6, 2024
NotTheEvilOne
removed
the
work in progress
Signed-off-by: Tobias Wolf <[email protected]>
NotTheEvilOne
force-pushed
the
prs/externalize-modulehandler-subclasses
branch
from
6e98a4d to
6e9aec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
ModuleHandlersubclasses to separate modules for easier maintainability. This PR requires #31 to be merged as it touches most of "rookify" modules.