Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrate mons module #54

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Add migrate mons module #54

merged 2 commits into from
Sep 3, 2024

Conversation

NotTheEvilOne
Copy link
Contributor

This PR adds the module migrating Ceph mon daemons to Rook.

Closes #19

@NotTheEvilOne NotTheEvilOne self-assigned this Jun 12, 2024
@NotTheEvilOne NotTheEvilOne added enhancement New feature or request module Rookify module labels Jun 12, 2024
@NotTheEvilOne NotTheEvilOne force-pushed the prs/add-migrate-mons-module branch from 058cac6 to 92dfa87 Compare June 12, 2024 08:12
@boekhorstb1
Copy link
Contributor

boekhorstb1 commented Jun 12, 2024

ok branch needs to be updated, rebase gives lots of conflicts.
Added backupbranch here: https://github.com/SovereignCloudStack/rookify/tree/backup/prs/add-migrate-mons-module

@boekhorstb1 boekhorstb1 force-pushed the prs/add-migrate-mons-module branch from 92dfa87 to dd78f83 Compare June 12, 2024 10:41
@boekhorstb1
Copy link
Contributor

boekhorstb1 commented Jun 12, 2024

Please check:

I get no warning and no outputs when my setup misses configuration or has wrong configuration. Note, when addingg example to config.yaml, I get warnings. For example if there is no ceph configuration in .ceph:

# No usefull logs and no errors
migration_modules:
- bla

compare to:

# Usefull logs and lots of errors
migration_modules:
- example

@NotTheEvilOne

@NotTheEvilOne
Copy link
Contributor Author

I added a separate issue (#56) for the described behavior as it is not part of the code changed with this PR.


while True:
result = self.ceph.mon_command("mon stat")
if result["num_mons"] >= 3:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the minimum number of running mons should be configurable via config file

@boekhorstb1
Copy link
Contributor

Hi there!

ok the code worked after I deleted an existing configmap as describe in the issue here: #65

deletion is probably bad, I guess the check needs to be skipped if configmap allready exists @NotTheEvilOne

)
)

while True:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check, if librados has a timeout for a mon connection, and automatically switches over to another mon, as we are probably shutting down the mon we are connected to.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is not the case, we have to implement some timeout/reconnect in ceph.py

@NotTheEvilOne NotTheEvilOne force-pushed the prs/add-migrate-mons-module branch from dd9e6e7 to 97a5690 Compare September 3, 2024 07:28
@NotTheEvilOne NotTheEvilOne merged commit bf5d999 into main Sep 3, 2024
2 checks passed
@NotTheEvilOne NotTheEvilOne deleted the prs/add-migrate-mons-module branch September 3, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module Rookify module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[module] migrate MONs
3 participants