-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migrate mons module #54
Conversation
058cac6
to
92dfa87
Compare
ok branch needs to be updated, rebase gives lots of conflicts. |
92dfa87
to
dd78f83
Compare
Please check: I get no warning and no outputs when my setup misses configuration or has wrong configuration. Note, when addingg
compare to:
|
3ce6cfb
to
c730a94
Compare
I added a separate issue (#56) for the described behavior as it is not part of the code changed with this PR. |
|
||
while True: | ||
result = self.ceph.mon_command("mon stat") | ||
if result["num_mons"] >= 3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the minimum number of running mons should be configurable via config file
Hi there! ok the code worked after I deleted an existing configmap as describe in the issue here: #65 deletion is probably bad, I guess the check needs to be skipped if configmap allready exists @NotTheEvilOne |
) | ||
) | ||
|
||
while True: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check, if librados has a timeout for a mon connection, and automatically switches over to another mon, as we are probably shutting down the mon we are connected to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is not the case, we have to implement some timeout/reconnect in ceph.py
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
dd9e6e7
to
97a5690
Compare
This PR adds the module migrating Ceph mon daemons to Rook.
Closes #19