Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README.md #72

Merged
merged 17 commits into from
Oct 23, 2024
Merged

docs: update README.md #72

merged 17 commits into from
Oct 23, 2024

Conversation

boekhorstb1
Copy link
Contributor

@boekhorstb1 boekhorstb1 commented Aug 22, 2024

  • updateing README.md
  • updateing docs/ files for osism and scs websites

Depends: #73

@boekhorstb1 boekhorstb1 self-assigned this Aug 22, 2024
@boekhorstb1 boekhorstb1 force-pushed the prs/adapt-docs-and-makefile branch 5 times, most recently from bda2241 to a7e3fb1 Compare August 22, 2024 11:36
Copy link
Contributor

@NotTheEvilOne NotTheEvilOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a separate PR for the Makefile changes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@boekhorstb1 boekhorstb1 mentioned this pull request Aug 26, 2024
@boekhorstb1
Copy link
Contributor Author

boekhorstb1 commented Aug 26, 2024

Please create a separate PR for the Makefile changes.

ok I removed makefile changes in this PR and I added makefile updates into this pr:

#73

@boekhorstb1 boekhorstb1 force-pushed the prs/adapt-docs-and-makefile branch from d648f92 to 4bbd6e7 Compare August 26, 2024 09:03
@NotTheEvilOne NotTheEvilOne force-pushed the prs/enhance-ceph-pools branch 7 times, most recently from 75c6ab3 to 463e5fb Compare September 3, 2024 08:07
Base automatically changed from prs/enhance-ceph-pools to main September 3, 2024 20:52
@boekhorstb1 boekhorstb1 force-pushed the prs/adapt-docs-and-makefile branch from 4bbd6e7 to e395c71 Compare September 4, 2024 07:46
@boekhorstb1 boekhorstb1 marked this pull request as ready for review September 4, 2024 07:48
@boekhorstb1 boekhorstb1 changed the title docs and setup: updating Makefile to work docs: updating README Sep 9, 2024
@boekhorstb1 boekhorstb1 force-pushed the prs/adapt-docs-and-makefile branch from e395c71 to 8a45938 Compare September 23, 2024 08:04
@boekhorstb1 boekhorstb1 mentioned this pull request Sep 24, 2024
4 tasks
@boekhorstb1 boekhorstb1 changed the title docs: updating README docs: update README.md and docs/ Sep 25, 2024
@boekhorstb1 boekhorstb1 marked this pull request as draft September 25, 2024 07:55
@boekhorstb1 boekhorstb1 changed the title docs: update README.md and docs/ docs: update README.md Sep 25, 2024
Copy link
Contributor

@NotTheEvilOne NotTheEvilOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that the changes look good so far.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@boekhorstb1 boekhorstb1 marked this pull request as ready for review October 7, 2024 09:36
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1 boekhorstb1 force-pushed the prs/adapt-docs-and-makefile branch from aa89d39 to 8f6910d Compare October 7, 2024 09:37
Copy link
Contributor

@NotTheEvilOne NotTheEvilOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boekhorstb1 boekhorstb1 merged commit 2cc2047 into main Oct 23, 2024
4 checks passed
@boekhorstb1 boekhorstb1 deleted the prs/adapt-docs-and-makefile branch October 23, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants