Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to configure which systemd unit services or targets to use #97

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Add support to configure which systemd unit services or targets to use #97

merged 2 commits into from
Nov 5, 2024

Conversation

NotTheEvilOne
Copy link
Contributor

@NotTheEvilOne NotTheEvilOne commented Nov 4, 2024 •
edited
Loading

Fixes: #95

@NotTheEvilOne NotTheEvilOne self-assigned this Nov 4, 2024
@NotTheEvilOne NotTheEvilOne added enhancement New feature or request framework Core components of rookify labels Nov 4, 2024
boekhorstb1
boekhorstb1 requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@boekhorstb1 boekhorstb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than config.example.yaml

config.example.osism.yaml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@NotTheEvilOne NotTheEvilOne force-pushed the prs/support-configurable-systemd-files branch from a5662de to d962cc9 Compare November 4, 2024 15:47
b1-lender
b1-lender approved these changes Nov 4, 2024
View reviewed changes
Copy link

@b1-lender b1-lender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NotTheEvilOne NotTheEvilOne force-pushed the prs/support-configurable-systemd-files branch from d962cc9 to 0ddf784 Compare November 4, 2024 16:00
@boekhorstb1 boekhorstb1 self-requested a review November 4, 2024 16:07
@NotTheEvilOne NotTheEvilOne force-pushed the prs/support-configurable-systemd-files branch from 0ddf784 to 31fb54c Compare November 5, 2024 08:41
@NotTheEvilOne NotTheEvilOne merged commit 4e0dfac into main Nov 5, 2024
3 checks passed
@NotTheEvilOne NotTheEvilOne deleted the prs/support-configurable-systemd-files branch November 5, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1-lender b1-lender b1-lender approved these changes

@boekhorstb1 boekhorstb1 boekhorstb1 approved these changes

Assignees

@NotTheEvilOne NotTheEvilOne

Labels
enhancement New feature or request framework Core components of rookify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normal cephadm setups use different labels than osism
3 participants
@NotTheEvilOne @boekhorstb1 @b1-lender