Skip to content

Commit

Permalink
Tested prior SharpHound collection file upload followed by newer vers…
Browse files Browse the repository at this point in the history
…ion file upload
  • Loading branch information
Mayyhem committed Dec 2, 2024
1 parent 6f5ce5b commit 0ad719d
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 4 deletions.
12 changes: 11 additions & 1 deletion packages/cue/bh/ad/ad.cue
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,13 @@ DoesAnyInheritedAceGrantOwnerRights: types.#StringEnum & {
representation: "doesanyinheritedacegrantownerrights"
}

OwnerSid: types.#StringEnum & {
symbol: "OwnerSid"
schema: "ad"
name: "Owner SID"
representation: "ownersid"
}

Properties: [
AdminCount,
CASecurityCollected,
Expand Down Expand Up @@ -868,7 +875,8 @@ Properties: [
GMSA,
MSA,
DoesAnyAceGrantOwnerRights,
DoesAnyInheritedAceGrantOwnerRights
DoesAnyInheritedAceGrantOwnerRights,
OwnerSid
]

// Kinds
Expand Down Expand Up @@ -1458,6 +1466,8 @@ ACLRelationships: [
WritePKINameFlag,
WriteOwnerLimitedRights,
OwnsLimitedRights,
OwnsRaw,
WriteOwnerRaw
]

// Edges that are used in pathfinding
Expand Down
2 changes: 1 addition & 1 deletion packages/go/ein/ad.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func convertOwnsEdgeToProperty(item IngestBase, itemProps map[string]any) {
if rightName, err := analysis.ParseKind(ace.RightName); err != nil {
continue
} else if rightName.Is(ad.Owns) || rightName.Is(ad.OwnsRaw) {
itemProps[common.OwnerObjectID.String()] = ace.PrincipalSID
itemProps[ad.OwnerSid.String()] = ace.PrincipalSID
return
}
}
Expand Down
11 changes: 9 additions & 2 deletions packages/go/graphschema/ad/ad.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions packages/javascript/bh-shared-ui/src/graphSchema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@ export enum ActiveDirectoryKindProperties {
MSA = 'msa',
DoesAnyAceGrantOwnerRights = 'doesanyacegrantownerrights',
DoesAnyInheritedAceGrantOwnerRights = 'doesanyinheritedacegrantownerrights',
OwnerSid = 'ownersid',
}
export function ActiveDirectoryKindPropertiesToDisplay(value: ActiveDirectoryKindProperties): string | undefined {
switch (value) {
Expand Down Expand Up @@ -633,6 +634,8 @@ export function ActiveDirectoryKindPropertiesToDisplay(value: ActiveDirectoryKin
return 'Does Any ACE Grant Owner Rights';
case ActiveDirectoryKindProperties.DoesAnyInheritedAceGrantOwnerRights:
return 'Does Any Inherited ACE Grant Owner Rights';
case ActiveDirectoryKindProperties.OwnerSid:
return 'Owner SID';
default:
return undefined;
}
Expand Down

0 comments on commit 0ad719d

Please sign in to comment.