Skip to content

Commit

Permalink
BED-5547 Don't try to login to dockerhub for PRs from forks (#1209)
Browse files Browse the repository at this point in the history
Forks don't have access to the necesssary secrets
  • Loading branch information
juggernot325 authored Mar 10, 2025
1 parent 55fe3ad commit 2feddb0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/actions/build-container-image/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ runs:
steps:
- uses: docker/login-action@v3
name: Authenticate with DockerHub Registry
if: ${{ github.event.repository.fork == false }}
with:
registry: docker.io
username: ${{ inputs.dockerhub_account }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable.build-container-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ jobs:
# TODO: don't pull actions but instead reference them from the source repo
# May need to adjust repo actions permissions to allow access from other org repos
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#allowing-access-to-components-in-a-private-repository
- if: ${{ github.repository != 'SpecterOps/BloodHound' }}
- if: ${{ github.repository != 'SpecterOps/BloodHound' && github.event.repository.fork == false }}
name: Checkout Reusable Workflows and Composite Actions
uses: actions/checkout@v4
with:
Expand Down

0 comments on commit 2feddb0

Please sign in to comment.