-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BED-5065: Display better error messages when creating a new user #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust where error is being checked on api
wes-mil
changed the title
BED_5065
BED-5065: Display better error messages when creating a new user
Dec 6, 2024
wes-mil
added
enhancement
New feature or request
user interface
A pull request containing changes affecting the UI code.
labels
Dec 6, 2024
mistahj67
reviewed
Dec 6, 2024
mistahj67
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, please have someone test this locally to verify UI changes
Co-authored-by: mistahj67 <[email protected]>
ALCooper12
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM and the UI displays the error message properly 👍🏾
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api
A pull request containing changes affecting the API code.
enhancement
New feature or request
user interface
A pull request containing changes affecting the UI code.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display more descriptive and better formatted errors when failing to create a new user.
Motivation and Context
This PR addresses: BED-5065
Why is this change required? What problem does it solve?
Previous error message would not indicate to the admin user why creating a new user was failing to be created.
How Has This Been Tested?
Creating a new user with a duplicate principal name now displays a more descriptive error message.
Screenshots (optional):
Duplicate principal name errors now display as:
Generic errors now display as:
Types of changes
Checklist: