Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: EnrollOnBehalfOf logic issue #1002

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix: EnrollOnBehalfOf logic issue #1002

merged 1 commit into from
Dec 9, 2024

Conversation

JonasBK
Copy link
Collaborator

@JonasBK JonasBK commented Dec 9, 2024

Description

Fixed a bug in the EnrollOnBehalfOf logic.

We now correctly check if the CA of the first CertTemplate is trusted for NTAuth.

Fixed harness tests to account for this as well.

Motivation and Context

This PR addresses: BED-4976

Same commit as this one, but this time with signed commit: #937

How Has This Been Tested?

Fixed harness tests for EnrollOnBehalfOf.

Checked that the edge is still generated and composition works for ESC3 with this dataset:
20231208161111_BloodHound.zip

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@JonasBK JonasBK added bug Something isn't working ticketed (automation only) Ticket has been created internally for tracking external This pull request is from an external contributor labels Dec 9, 2024
@JonasBK JonasBK merged commit a420a32 into main Dec 9, 2024
4 checks passed
@JonasBK JonasBK deleted the BED-4976-esc3-bug-2 branch December 9, 2024 18:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working external This pull request is from an external contributor ticketed (automation only) Ticket has been created internally for tracking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants