Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4624: Backend Logic to Redirect User to UI on SSO Login Failure #1003

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

iustinum
Copy link
Contributor

@iustinum iustinum commented Dec 9, 2024

Description

Errors occurred during SSO Logins are currently displayed as raw JSON. This PR implements the backend logic to return the user with a user-friendly logic displayed.

Motivation and Context

This PR addresses: BED-4624

How Has This Been Tested?

I created a new auth0 SSO provider and replicated the error cases from the acceptance criteria. I then verified that expected error messages have correctly been populated as query parameter. Note that this changeset covers error cases specifically handled by SSO handlers, not all error scenarios in the acceptance criteria.

For example, on cases when a user tried logging in with SSO that has been deleted, they would expect to be redirected to:

http://bhe.localhost/ui/login?error=SSO+Provider+not+found

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@iustinum iustinum added bug Something isn't working api A pull request containing changes affecting the API code. labels Dec 9, 2024
@iustinum iustinum self-assigned this Dec 9, 2024
Copy link
Contributor

@ALCooper12 ALCooper12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But more importantly, what does UI think? 👀

@iustinum iustinum merged commit d7025ff into main Dec 13, 2024
4 checks passed
@iustinum iustinum deleted the BED-4624 branch December 13, 2024 20:03
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code. bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants