Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PQE-6 - Migrate E2E Disable Users Tests To BDD #1019

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Conversation

ykaiboussiSO
Copy link

@ykaiboussiSO ykaiboussiSO commented Dec 16, 2024

Description

This PR introduces E2E Behavior Driven Development Framework using Cucumber-JS and Playwright API.

Motivation and Context

We are currently exploring tools and best practices to automate Acceptance Criteria.

How Has This Been Tested?

Tested E2E implementation against local BHCE instance.

5 scenarios (5 passed)
30 steps (30 passed)
0m07.044s (executing steps: 0m06.884s)
➜  BloodHound git:(PQE-6)

Checklist:

Copy link

github-actions bot commented Dec 16, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ykaiboussiSO
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

cmd/e2e/package.json Outdated Show resolved Hide resolved
cmd/e2e/.env-cmdrc.example Outdated Show resolved Hide resolved
cmd/e2e/.env.example Outdated Show resolved Hide resolved
cmd/e2e/src/helpers/hashpassword.ts Outdated Show resolved Hide resolved
cmd/e2e/src/helpers/hashpassword.ts Outdated Show resolved Hide resolved
@ykaiboussiSO ykaiboussiSO force-pushed the PQE-6 branch 2 times, most recently from ace6aee to a6eeca3 Compare December 23, 2024 20:26
@ykaiboussiSO ykaiboussiSO changed the title PQE-6 PQE-6 - Migrate E2E Disable Users Tests To BDD Dec 23, 2024
@ykaiboussiSO ykaiboussiSO force-pushed the PQE-6 branch 2 times, most recently from b18e1e0 to 9748c4d Compare January 2, 2025 21:46
@ykaiboussiSO ykaiboussiSO marked this pull request as ready for review January 2, 2025 21:56
@ykaiboussiSO ykaiboussiSO requested a review from benwaples January 2, 2025 21:59
cmd/e2e/README.md Outdated Show resolved Hide resolved
cmd/e2e/prisma/cleanup.ts Outdated Show resolved Hide resolved
cmd/e2e/prisma/cleanup.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@benwaples benwaples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I was able to easily set up the project and run tests. I left a couple comments, mostly minor changes, but I think updating the readme will help for future people setting up the project as well.

Ill do another review after any changes accepted/made!

cmd/e2e/prisma/seed.ts Outdated Show resolved Hide resolved
cmd/e2e/prisma/cleanup.ts Outdated Show resolved Hide resolved
cmd/e2e/prisma/cleanup.ts Outdated Show resolved Hide resolved
Signed-off-by: ykaiboussiSO <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants