Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4963: Clean Up and Tighten Enforcement of Linters #1037

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

superlinkx
Copy link
Contributor

Description

Describe your changes in detail

This PR is composed of several separate commits for different fixes and improvements to code that was showing up in our linter warnings.

  • Removal of our own errors package, leading to a refactor that switches all usages to the stdlib errors package
  • Clean up of unused code, incorrect function signatures, and other minor fixups recommended by the linter
  • Two problematic deprecations were added to our ignore list for now, with tickets generated to cover properly resolving them in the future
  • Now that there were no warnings, upgraded all existing warn level issues to error level
  • Enabled errcheck as our new warning to start the long process of resolving errcheck issues, before promoting it to error level (no other linters are being turned on yet since errcheck is going to be a very large undertaking on its own, we'll evaluate other useful linter rules after errcheck graduates)

Motivation and Context

This PR addresses: BED-4963

Why is this change required? What problem does it solve?

Our linter warnings were piling up, and they're not super helpful to devs when there's that many. This PR aims to resolve existing warnings (or add exclusions until proper fixes can be evaluated), graduate all existing warnings to error level events (requiring devs to resolve or add exclusions before merging), and enable the next linter rule in our quest for continuous improvement.

How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

All code builds and tests fine after the changes. No logical changes should exist outside of wiring up an unused part of the OpenCypher compiler.

Types of changes

  • Chore (a change that does not modify the application functionality)

Checklist:

@superlinkx superlinkx added the tooling This updates developer tooling label Dec 20, 2024
@superlinkx superlinkx self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling This updates developer tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant