BED-4963: Clean Up and Tighten Enforcement of Linters #1037
+135
−412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail
This PR is composed of several separate commits for different fixes and improvements to code that was showing up in our linter warnings.
errcheck
as our new warning to start the long process of resolvingerrcheck
issues, before promoting it to error level (no other linters are being turned on yet since errcheck is going to be a very large undertaking on its own, we'll evaluate other useful linter rules after errcheck graduates)Motivation and Context
This PR addresses: BED-4963
Why is this change required? What problem does it solve?
Our linter warnings were piling up, and they're not super helpful to devs when there's that many. This PR aims to resolve existing warnings (or add exclusions until proper fixes can be evaluated), graduate all existing warnings to error level events (requiring devs to resolve or add exclusions before merging), and enable the next linter rule in our quest for continuous improvement.
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
All code builds and tests fine after the changes. No logical changes should exist outside of wiring up an unused part of the OpenCypher compiler.
Types of changes
Checklist: