-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BED-5026 CoerceAndRelayNTLMToLDAP(s) Post Processing #1093
Draft
mvlipka
wants to merge
13
commits into
main
Choose a base branch
from
BED-5026/CoerceAndRelayNTLMToLDAP-postprocessing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,699
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o keep cohesion with existing LDAPs naming conventions. Added CoerceAndRelayNTLMToLDAPs integration test
…ing error if a property cant be found
…Added IsDC property to AD schema
…ness in order to generate edges for integration test
…provided test harness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
work in progress
This pull request is a work in progress and should not be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the new
CoerceAndRelayNTLMToLDAP
andCoerceAndRelayNTLMToLDAPs
edges to our post processing as well as the integration testsMotivation and Context
This PR addresses: BED-5026 & BED-5028
How Has This Been Tested?
Integration tests were written in order to test
Screenshots (optional):
Types of changes
Checklist: