Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Update Asset Group Selectors" endpoint #138

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Conversation

maffkipp
Copy link
Contributor

@maffkipp maffkipp commented Oct 11, 2023

Description

  • Adds the POST /v2/asset-groups/{asset_group_id}/selectors endpoint into BHCE
  • Fixes a bug that caused this endpoint to always return empty lists of selectors
  • Updates the documentation to reflect the correct request/response types for this endpoint

Motivation and Context

We are building a new asset group management page, which will need the ability to add and remove asset group selectors.

How Has This Been Tested?

  • This handler has existing tests that were ported over along with it

Screenshots (if appropriate):

Screenshot 2023-10-11 at 2 53 25 PM

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@maffkipp maffkipp self-assigned this Oct 11, 2023
@superlinkx
Copy link
Contributor

Looks good!

@maffkipp maffkipp merged commit 026ca83 into main Oct 16, 2023
@maffkipp maffkipp deleted the update-group-endpoint branch October 16, 2023 20:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants