Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated icon definitions #162

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Consolidated icon definitions #162

merged 5 commits into from
Oct 25, 2023

Conversation

maffkipp
Copy link
Contributor

Description

  • We had multiple identical lists of icon definitions spread across a few different files, this change consolidates them down to one icons.ts file in the shared UI library.

Motivation and Context

  • Prevents icons in different parts of the app from potentially getting out of sync with each other

How Has This Been Tested?

  • Ensured icons still display in each graph and in various other menus

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@maffkipp maffkipp self-assigned this Oct 23, 2023
@maffkipp maffkipp merged commit bb82f02 into main Oct 25, 2023
2 checks passed
@maffkipp maffkipp deleted the consolidate-icons branch October 25, 2023 20:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants