Edge entity panel updates #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwaples
approved these changes
Jan 16, 2024
benwaples
reviewed
Jan 16, 2024
| '$SDBytes = New-Object byte[] ($SD.BinaryLength)\n' + | ||
| '$SD.GetBinaryForm($SDBytes, 0)'} | ||
| </Typography> | ||
|
|
||
| <Typography variant='body2'> | ||
| Next, we need to set this newly created security descriptor in the | ||
| msDS-AllowedToActOnBehalfOfOtherIdentity field of the comptuer account we're taking over, again |
There was a problem hiding this comment.
Should this be computer? Or is comptuer the french computer 😉
There was a problem hiding this comment.
Merci beaucoup monsieur 👌
|
Gave it a quick read through and it looks good to me |
rvazarkar
approved these changes
Jan 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various improvements in the edge entity panel abuse info incl:
Motivation and Context
How Has This Been Tested?
I have checked that the edge entity panels modified with more that just a single word replacement still render correctly when running BH.
Screenshots (if appropriate):
Types of changes
Checklist: