Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: esc6a post #322

Merged
merged 14 commits into from
Jan 24, 2024
Merged

feat: esc6a post #322

merged 14 commits into from
Jan 24, 2024

Conversation

urangel
Copy link
Contributor

@urangel urangel commented Jan 17, 2024

Description

This changeset implements post-processing for the ADCSESC6a edge. Some utility was also added to directly use data output from a diagram originating from an arrows.app export to JSON for instantiating test harnesses rather than manually transcribing the data.

Motivation and Context

The utility for transcribing arrows.app JSON output saves time and avoids possibly having the reference be out of sync with the test. This code needs extending for it to handle all node types and node property values as it currently only functions for the subset of nodes and properties that were included in these new integration tests.

How Has This Been Tested?

Integration tests have been added covering several different scenarios.

Screenshots (if appropriate):

ESC6a Harness principal edges
ESC6a Harness Template1
ESC6a Harness ECA
ESC6a Harness Template2

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@urangel urangel marked this pull request as draft January 17, 2024 16:30
@urangel urangel marked this pull request as ready for review January 19, 2024 14:52
packages/go/analysis/ad/adcs.go Outdated Show resolved Hide resolved
packages/go/analysis/ad/adcs.go Show resolved Hide resolved
packages/go/analysis/ad/adcs.go Outdated Show resolved Hide resolved
packages/go/analysis/ad/adcs.go Outdated Show resolved Hide resolved
packages/go/analysis/ad/adcs.go Outdated Show resolved Hide resolved
packages/go/analysis/ad/adcs.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@JonasBK JonasBK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two comments. Let me know if they don't make sense :)

packages/go/analysis/ad/adcs.go Outdated Show resolved Hide resolved
packages/go/analysis/ad/adcs.go Outdated Show resolved Hide resolved
Copy link
Contributor

@irshadaj irshadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for accommodating all those change requests, I know how painful that can be in such a complex changeset.

Copy link
Collaborator

@JonasBK JonasBK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work man! 🙌

Copy link
Contributor

@rvazarkar rvazarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seal of approval

@irshadaj irshadaj merged commit 0399f59 into main Jan 24, 2024
2 checks passed
@irshadaj irshadaj deleted the BED3998 branch January 24, 2024 15:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants