-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: esc6a post #322
feat: esc6a post #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two comments. Let me know if they don't make sense :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for accommodating all those change requests, I know how painful that can be in such a complex changeset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work man! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seal of approval
…now that they are in main
…ycheck, return error on filterTempResultsForESC6a
Description
This changeset implements post-processing for the ADCSESC6a edge. Some utility was also added to directly use data output from a diagram originating from an arrows.app export to JSON for instantiating test harnesses rather than manually transcribing the data.
Motivation and Context
The utility for transcribing arrows.app JSON output saves time and avoids possibly having the reference be out of sync with the test. This code needs extending for it to handle all node types and node property values as it currently only functions for the subset of nodes and properties that were included in these new integration tests.
How Has This Been Tested?
Integration tests have been added covering several different scenarios.
Screenshots (if appropriate):
Types of changes
Checklist: